Re: [PR] Fix insert into mode is not restriction for BE storage_flood_stage_usage_percent param [doris]

["cambyzju (via GitHub)" <gi...@apache.org>]

cambyzju commented on code in PR #36657:
URL: https://github.com/apache/doris/pull/36657#discussion_r1810294110


##########
be/src/runtime/load_stream.cpp:
##########
@@ -178,6 +179,19 @@ Status TabletStream::add_segment(const PStreamHeader& header, butil::IOBuf* data
     DCHECK(header.has_segment_statistics());
     SegmentStatistics stat(header.segment_statistics());
     TabletSchemaSPtr flush_schema;
+    DataDir* data_dir = nullptr;
+
+    TabletSharedPtr tablet = StorageEngine::instance()->tablet_manager()->get_tablet(header.tablet_id());
+    if (tablet != nullptr) {
+        data_dir = tablet->data_dir();				 
+    }
+
+    if (data_dir != nullptr &&
+        data_dir->reach_capacity_limit(stat.data_size + stat.index_size)) {
+        LOG(INFO) << "segment size is " << (stat.data_size + stat.index_size);

Review Comment:
   maybe debug log is better.
   After disk usage is high, lots of these logs will take large disk space.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org