[GitHub] [iceberg] kbendick commented on a diff in pull request #4958: Shutdown refresh token executor service during REST catalog client close

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4958:
URL: https://github.com/apache/iceberg/pull/4958#discussion_r889628278


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -369,6 +369,7 @@ public void close() throws IOException {
       ScheduledExecutorService service = refreshExecutor;
       this.refreshExecutor = null;
 
+      service.shutdown();

Review Comment:
   Good catch.
   
   One question: do we potentially want to do this inside of a try block? [Looking at the javadocs](https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ExecutorService.html#shutdown--), it seems like the only exception it can throw is `SecurityException` which likely shouldn't happen if the executor service was started.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org