You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/02/09 11:10:26 UTC
[GitHub] [ozone] smengcl commented on pull request #3003: HDDS-6208. New checkstyle: WhitespaceAround
smengcl commented on pull request #3003:
URL: https://github.com/apache/ozone/pull/3003#issuecomment-1033644365
@adoroszlai
I have fixed ALL the new `WhitespaceAround` checkstyle warnings on the latest master branch. Pls take a look.
Apart from that, this PR includes:
1. Checkstyle XML one-line change
2. Print more human readable output with the new sed replacement lines in `checkstyle.sh`, which was due to XML escape characters in `checkstyle-errors.xml` files. For example,
what was:
```
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
540: 'if' is not followed by whitespace.
859: 'try' is not followed by whitespace.
859: '{' is not preceded with whitespace.
953: 'for' is not followed by whitespace.
959: 'for' is not followed by whitespace.
1018: 'if' is not followed by whitespace.
1018: '{' is not preceded with whitespace.
1160: 'if' is not followed by whitespace.
1164: '<=' is not followed by whitespace.
1166: '>=' is not followed by whitespace.
1511: 'for' is not followed by whitespace.
1549: 'try' is not followed by whitespace.
1549: '{' is not preceded with whitespace.
1553: 'if' is not followed by whitespace.
1553: '{' is not preceded with whitespace.
1562: '}' is not followed by whitespace.
1562: 'catch' is not preceded with whitespace.
1562: '{' is not preceded with whitespace.
```
is now:
```
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
540: 'if' is not followed by whitespace.
859: 'try' is not followed by whitespace.
859: '{' is not preceded with whitespace.
953: 'for' is not followed by whitespace.
959: 'for' is not followed by whitespace.
1018: 'if' is not followed by whitespace.
1018: '{' is not preceded with whitespace.
1160: 'if' is not followed by whitespace.
1164: '<=' is not followed by whitespace.
1166: '>=' is not followed by whitespace.
1511: 'for' is not followed by whitespace.
1549: 'try' is not followed by whitespace.
1549: '{' is not preceded with whitespace.
1553: 'if' is not followed by whitespace.
1553: '{' is not preceded with whitespace.
1562: '}' is not followed by whitespace.
1562: 'catch' is not preceded with whitespace.
1562: '{' is not preceded with whitespace.
```
Merging this shouldn't cause too much distruption to existing PRs if any, as those are all straight forward white space additions and are easy to do conflict resolution if it happens.
Preferrably we should review this as soon as possible. It would take longer and longer to merge as new PRs are merged.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org