You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/12 16:26:28 UTC
[GitHub] [flink] pnowojski commented on a change in pull request #13565: [FLINK-17073][checkpointing] Backpressure checkpointing on slow cleanup
pnowojski commented on a change in pull request #13565:
URL: https://github.com/apache/flink/pull/13565#discussion_r503350616
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -531,6 +527,30 @@ private void dispose(boolean releaseState, CheckpointsCleaner checkpointsCleaner
}
}
+ @Override
+ public void discard() {
+ synchronized (lock) {
+ if (stateDiscarded) {
+ Preconditions.checkState(discarded, "Checkpoint should be disposed before being discarded");
+ return;
+ } else {
+ stateDiscarded = true;
+ }
+ }
Review comment:
Why do we need this check now? As far as I can tell, previously it was not needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org