You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/11/08 20:14:22 UTC
[GitHub] [superset] corbinrobb opened a new pull request, #22068: test: Fix act errors in DndColumnSelectControl tests
corbinrobb opened a new pull request, #22068:
URL: https://github.com/apache/superset/pull/22068
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Cleans up a few act errors in
- superset-frontend/src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx
- superset-frontend/src/explore/components/controls/DndColumnSelectControl/Option.test.tsx
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- cd into `/superset-frontend`
- `npm run test -- src/explore/components/controls/DndColumnSelectControl/Option.test.tsx`
- `npm run test -- src/explore/components/controls/DndColumnSelectControl/OptionWrapper.test.tsx`
- Check for act errors
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #22068: test: Fix act errors in DndColumnSelectControl tests
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #22068:
URL: https://github.com/apache/superset/pull/22068#issuecomment-1307981432
Welcome back @corbinrobb!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #22068: test: Fix act errors in DndColumnSelectControl tests
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged PR #22068:
URL: https://github.com/apache/superset/pull/22068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org