You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/25 16:24:52 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Ouss4 opened a new pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
patacongo edited a comment on pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#issuecomment-619405282
This is a trivial change that does not warrant running the PR changes (one line added to a .txt file)
However, it will be interest to verify that it passes the PR checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] patacongo commented on pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#issuecomment-619405282
This is a trivial change that does not warrant running the PR changes (one line added to a .txt file)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#discussion_r415119282
##########
File path: DISCLAIMER-WIP
##########
@@ -11,6 +11,7 @@ a list of known issues the project is currently aware of (note that this list, b
is likely to be incomplete):
* Releases may have incomplete licensing conditions.
+ * Some ASF files don't have the correct headers.
Review comment:
Looks good to me. I think that makes the state of things clear for people outside the project which I think was Justin's request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#issuecomment-619407295
I think we should put more text in here explaining that most of the code currently with BSD headers has a code grant from Greg, and we are working on updating the headers in the coming releases and obtaining approvals from other right holders as we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#issuecomment-619434281
> This did not get the suggested changed included
I submitted a new PR for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#issuecomment-619429035
This did not get the suggested changed included
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #874: Update the disclaimer to note that some ASF files don't have correct ASF header
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #874:
URL: https://github.com/apache/incubator-nuttx/pull/874#discussion_r415104736
##########
File path: DISCLAIMER-WIP
##########
@@ -11,6 +11,7 @@ a list of known issues the project is currently aware of (note that this list, b
is likely to be incomplete):
* Releases may have incomplete licensing conditions.
+ * Some ASF files don't have the correct headers.
Review comment:
```suggestion
* Some ASF files still have BSD headers. Most of the top contributors have signed an ICLA and we are working on updating the headers and getting approvals from other copyright holders.
```
@btashton I pretty much copied what you wrote.
Please if you get anything to add/remove use the suggestions and we squash the commits when merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org