You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Alan Woodward <al...@flax.co.uk> on 2016/05/13 09:36:05 UTC

Solr distributed tests

Hi all,

We currently have 109 tests in solr that extend AbstractDistribZkTestBase.  These all rely on 'legacy cloud' behaviour - the test creates a bunch of core directories and properties files, which then automagically instantiate a collection when they are loaded.  This is behaviour that ideally we want to deprecate and remove, migrating everything to a 'ZK is truth' mode; the fact that almost all our cloud-based tests rely on this behaviour is a bit of a hindrance here.

Starting next week, I'd like to migrate as many of these tests as possible to using SolrCloudTestCase instead.  I'll move them in groups, creating individual JIRAs for each group, to break things down a bit.  A lot of these tests are from the very early days of Solr Cloud, before many of the APIs were added, so they can probably be simplified at the same time.

I migrated the SolrJ tests last week in SOLR-9065, and managed to tread on the toes of a bunch of people already working on them, so this is a heads-up to try and avoid that happening again.  If anybody is actively working on a test that's derived from AbstractDistribZkTestBase, please let me know, and I can either hold off on migrating that test, or help out with moving it across.  And of course, if anybody else wants to join in, then feel free :)

Alan Woodward
www.flax.co.uk



Re: Solr distributed tests

Posted by Joel Bernstein <jo...@gmail.com>.
The refactoring of the Solrj tests made things much cleaner and faster.
Nice work!

Joel Bernstein
http://joelsolr.blogspot.com/

On Fri, May 13, 2016 at 10:20 AM, David Smiley <da...@gmail.com>
wrote:

> Thanks for doing this!
>
> On Fri, May 13, 2016 at 5:36 AM Alan Woodward <al...@flax.co.uk> wrote:
>
>> Hi all,
>>
>> We currently have 109 tests in solr that extend
>> AbstractDistribZkTestBase.  These all rely on 'legacy cloud' behaviour -
>> the test creates a bunch of core directories and properties files, which
>> then automagically instantiate a collection when they are loaded.  This is
>> behaviour that ideally we want to deprecate and remove, migrating
>> everything to a 'ZK is truth' mode; the fact that almost all our
>> cloud-based tests rely on this behaviour is a bit of a hindrance here.
>>
>> Starting next week, I'd like to migrate as many of these tests as
>> possible to using SolrCloudTestCase instead.  I'll move them in groups,
>> creating individual JIRAs for each group, to break things down a bit.  A
>> lot of these tests are from the very early days of Solr Cloud, before many
>> of the APIs were added, so they can probably be simplified at the same time.
>>
>> I migrated the SolrJ tests last week in SOLR-9065, and managed to tread
>> on the toes of a bunch of people already working on them, so this is a
>> heads-up to try and avoid that happening again.  If anybody is actively
>> working on a test that's derived from AbstractDistribZkTestBase, please let
>> me know, and I can either hold off on migrating that test, or help out with
>> moving it across.  And of course, if anybody else wants to join in, then
>> feel free :)
>>
>> Alan Woodward
>> www.flax.co.uk
>>
>>
>> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>

Re: Solr distributed tests

Posted by Erick Erickson <er...@gmail.com>.
"Tread on the toes"? Not in my book!

Go Alan! Go!....

On Fri, May 13, 2016 at 7:25 AM, Varun Thacker
<va...@gmail.com> wrote:
> This should reduce the runtime of the tests by quite a bit as well :)
>
> On Fri, May 13, 2016 at 7:50 PM, David Smiley <da...@gmail.com>
> wrote:
>>
>> Thanks for doing this!
>>
>> On Fri, May 13, 2016 at 5:36 AM Alan Woodward <al...@flax.co.uk> wrote:
>>>
>>> Hi all,
>>>
>>> We currently have 109 tests in solr that extend
>>> AbstractDistribZkTestBase.  These all rely on 'legacy cloud' behaviour - the
>>> test creates a bunch of core directories and properties files, which then
>>> automagically instantiate a collection when they are loaded.  This is
>>> behaviour that ideally we want to deprecate and remove, migrating everything
>>> to a 'ZK is truth' mode; the fact that almost all our cloud-based tests rely
>>> on this behaviour is a bit of a hindrance here.
>>>
>>> Starting next week, I'd like to migrate as many of these tests as
>>> possible to using SolrCloudTestCase instead.  I'll move them in groups,
>>> creating individual JIRAs for each group, to break things down a bit.  A lot
>>> of these tests are from the very early days of Solr Cloud, before many of
>>> the APIs were added, so they can probably be simplified at the same time.
>>>
>>> I migrated the SolrJ tests last week in SOLR-9065, and managed to tread
>>> on the toes of a bunch of people already working on them, so this is a
>>> heads-up to try and avoid that happening again.  If anybody is actively
>>> working on a test that's derived from AbstractDistribZkTestBase, please let
>>> me know, and I can either hold off on migrating that test, or help out with
>>> moving it across.  And of course, if anybody else wants to join in, then
>>> feel free :)
>>>
>>> Alan Woodward
>>> www.flax.co.uk
>>>
>>>
>> --
>> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
>> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
>> http://www.solrenterprisesearchserver.com
>
>
>
>
> --
>
>
> Regards,
> Varun Thacker

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Re: Solr distributed tests

Posted by Varun Thacker <va...@gmail.com>.
This should reduce the runtime of the tests by quite a bit as well :)

On Fri, May 13, 2016 at 7:50 PM, David Smiley <da...@gmail.com>
wrote:

> Thanks for doing this!
>
> On Fri, May 13, 2016 at 5:36 AM Alan Woodward <al...@flax.co.uk> wrote:
>
>> Hi all,
>>
>> We currently have 109 tests in solr that extend
>> AbstractDistribZkTestBase.  These all rely on 'legacy cloud' behaviour -
>> the test creates a bunch of core directories and properties files, which
>> then automagically instantiate a collection when they are loaded.  This is
>> behaviour that ideally we want to deprecate and remove, migrating
>> everything to a 'ZK is truth' mode; the fact that almost all our
>> cloud-based tests rely on this behaviour is a bit of a hindrance here.
>>
>> Starting next week, I'd like to migrate as many of these tests as
>> possible to using SolrCloudTestCase instead.  I'll move them in groups,
>> creating individual JIRAs for each group, to break things down a bit.  A
>> lot of these tests are from the very early days of Solr Cloud, before many
>> of the APIs were added, so they can probably be simplified at the same time.
>>
>> I migrated the SolrJ tests last week in SOLR-9065, and managed to tread
>> on the toes of a bunch of people already working on them, so this is a
>> heads-up to try and avoid that happening again.  If anybody is actively
>> working on a test that's derived from AbstractDistribZkTestBase, please let
>> me know, and I can either hold off on migrating that test, or help out with
>> moving it across.  And of course, if anybody else wants to join in, then
>> feel free :)
>>
>> Alan Woodward
>> www.flax.co.uk
>>
>>
>> --
> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
> LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
> http://www.solrenterprisesearchserver.com
>



-- 


Regards,
Varun Thacker

Re: Solr distributed tests

Posted by David Smiley <da...@gmail.com>.
Thanks for doing this!

On Fri, May 13, 2016 at 5:36 AM Alan Woodward <al...@flax.co.uk> wrote:

> Hi all,
>
> We currently have 109 tests in solr that extend
> AbstractDistribZkTestBase.  These all rely on 'legacy cloud' behaviour -
> the test creates a bunch of core directories and properties files, which
> then automagically instantiate a collection when they are loaded.  This is
> behaviour that ideally we want to deprecate and remove, migrating
> everything to a 'ZK is truth' mode; the fact that almost all our
> cloud-based tests rely on this behaviour is a bit of a hindrance here.
>
> Starting next week, I'd like to migrate as many of these tests as possible
> to using SolrCloudTestCase instead.  I'll move them in groups, creating
> individual JIRAs for each group, to break things down a bit.  A lot of
> these tests are from the very early days of Solr Cloud, before many of the
> APIs were added, so they can probably be simplified at the same time.
>
> I migrated the SolrJ tests last week in SOLR-9065, and managed to tread on
> the toes of a bunch of people already working on them, so this is a
> heads-up to try and avoid that happening again.  If anybody is actively
> working on a test that's derived from AbstractDistribZkTestBase, please let
> me know, and I can either hold off on migrating that test, or help out with
> moving it across.  And of course, if anybody else wants to join in, then
> feel free :)
>
> Alan Woodward
> www.flax.co.uk
>
>
> --
Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker
LinkedIn: http://linkedin.com/in/davidwsmiley | Book:
http://www.solrenterprisesearchserver.com