You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "RussellSpitzer (via GitHub)" <gi...@apache.org> on 2025/05/16 17:17:02 UTC

[PR] 1.9.1 release fixes [iceberg]

RussellSpitzer opened a new pull request, #13081:
URL: https://github.com/apache/iceberg/pull/13081

   As discussed on the ML, the following are cherry-picks of fixes we want for 1.9.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093523511


##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   `.as(...)` needs to be applied before the condition check of `isEqualTo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093600793


##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093539632


##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   This is already merged, do you think it's worth changing in this cherrypick? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#issuecomment-2887285271

   Note if someone tries to merge this that isn't me, we want to do a Rebase and merge for this PR and not a Squash


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer commented on PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#issuecomment-2887567333

   Merged, Thanks @nastra , @amogh-jahagirdar , @stevenzwu , @kevinjqliu  For review. I'll start a RC in a bit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093523511


##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   ".as(...)" needs to be used before the condition check of `isEqualTo`



##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   `.as(...)` needs to be used before the condition check of `isEqualTo`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "stevenzwu (via GitHub)" <gi...@apache.org>.
stevenzwu commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093599959


##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
                 + ")");
   }
 
+  @Test
+  public void testVersionNotUnspecified() {
+    assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+  }
+
+  @Test
+  public void testVersionMatchesSystemProperty() {
+    assumeThat(System.getProperty("project.version")).isNotNull();
+    assertThat(IcebergBuild.version())
+        .isEqualTo(System.getProperty("project.version"))
+        .as("IcebergBuild.version() should match system property project.version");

Review Comment:
   no need to change this cherrypick. 
   
   maybe we can just fix the main branch later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] 1.9.1 release fixes [iceberg]

Posted by "RussellSpitzer (via GitHub)" <gi...@apache.org>.
RussellSpitzer merged PR #13081:
URL: https://github.com/apache/iceberg/pull/13081


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org