You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/09 06:44:54 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
HyukjinKwon opened a new pull request #32103:
URL: https://github.com/apache/spark/pull/32103
### What changes were proposed in this pull request?
This PR proposes to fix:
```
import pyspark.pandas as pp
```
to
```
import pyspark.pandas as ps
```
### Why are the changes needed?
`pp` might sound offensive in some contexts.
### Does this PR introduce _any_ user-facing change?
The change is in master only. We'll use `ps` as the short name instead of `pp`.
### How was this patch tested?
The CI in this PR will test it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816501496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816471877
**[Test build #137120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137120/testReport)** for PR 32103 at commit [`5cf6058`](https://github.com/apache/spark/commit/5cf6058092f40e8675082004e8fb77a85c550f7f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on a change in pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
itholic commented on a change in pull request #32103:
URL: https://github.com/apache/spark/pull/32103#discussion_r610411429
##########
File path: python/pyspark/pandas/accessors.py
##########
@@ -265,24 +265,24 @@ def apply_batch(self, func, args=(), **kwds) -> "DataFrame":
DataFrame.applymap: For elementwise operations.
DataFrame.aggregate: Only perform aggregating type operations.
DataFrame.transform: Only perform transforming type operations.
- Series.koalas.transform_batch: transform the search as each pandas chunpp.
+ Series.koalas.transform_batch: transform the search as each pandas chunks.
Review comment:
Thanks for fixing this 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816471877
**[Test build #137120 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137120/testReport)** for PR 32103 at commit [`5cf6058`](https://github.com/apache/spark/commit/5cf6058092f40e8675082004e8fb77a85c550f7f).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816507579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #32103:
URL: https://github.com/apache/spark/pull/32103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816507578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816822774
Thanks! Is this PR aimed to change the main code only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-817081273
I am closing in favour of https://github.com/apache/spark/pull/32108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816490428
**[Test build #137120 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137120/testReport)** for PR 32103 at commit [`5cf6058`](https://github.com/apache/spark/commit/5cf6058092f40e8675082004e8fb77a85c550f7f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32103: [SPARK-35001][PYTHON] Use ps as the short name instead of pp in pandas-on-Spark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32103:
URL: https://github.com/apache/spark/pull/32103#issuecomment-816452768
cc @ueshin, @itholic, and @xinrong-databricks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org