You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/12 13:07:50 UTC

[GitHub] [skywalking-nodejs] tom-pytel edited a comment on pull request #50: Segment reference and reporting overhaul

tom-pytel edited a comment on pull request #50:
URL: https://github.com/apache/skywalking-nodejs/pull/50#issuecomment-839757159


   > > "peer" removed from Context.newExitSpan() and is now treated just like the other parameters.
   > 
   > If there is no `peer`, the `sw8` header could not be assembled correctly. How do the test cases work?
   
   There is a peer it is just being set explicitly after the call rather than passing as parameter to `newExitSpan()` and being set in this function. A minor change to allow consolidating common functionality of newExitSpan, newEntrySpan and newLocalSpan.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org