[jira] [Commented] (TINKERPOP-2154) GraphBinary: Serializers should release resources in case of failures

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16763512#comment-16763512 ] 

ASF GitHub Bot commented on TINKERPOP-2154:
-------------------------------------------

jorgebay commented on pull request #1058: TINKERPOP-2154 GraphBinary: Release working buffers on failure
URL: https://github.com/apache/tinkerpop/pull/1058
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2154
   
   Ensures that reference counts of allocated buffers are set to 0 when there is a failure during serialization.
   
   Includes a test for memory allocation when introducing failures.
   
   VOTE +1
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GraphBinary: Serializers should release resources in case of failures
> ---------------------------------------------------------------------
>
>                 Key: TINKERPOP-2154
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2154
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 3.4.0
>            Reporter: Jorge Bay
>            Assignee: Jorge Bay
>            Priority: Major
>             Fix For: 3.4.1
>
>
> {{TypeSerializer<T>}} implementations should release the working {{ByteBuf}} instances when writing fails. This is specially concerning for composite types (List/Map/ByteCode/...) that can contain arbitrary nested types.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)