You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "fallintoplace (via GitHub)" <gi...@apache.org> on 2026/07/25 20:41:05 UTC

[PR] fix(manifest): return defensive metadata copies [iceberg-go]

fallintoplace opened a new pull request, #1544:
URL: https://github.com/apache/iceberg-go/pull/1544

   ## What changed
   
   - Clone key metadata returned by ManifestFile.
   - Deep-copy partition summaries, including bounds and nullable ContainsNaN values.
   - Copy the nullable first row ID before returning it.
   - Reuse the partition summary copy helper for builder inputs and getter outputs.
   
   ## Why
   
   ManifestFile getters exposed slices and pointers owned by decoded manifest-list entries. A caller could mutate key metadata, partition bounds, summary flags, or first row IDs and silently change later planning or manifest rewrite behavior.
   
   The regression test mutates every affected getter and verifies that subsequent reads remain unchanged.
   
   ## Testing
   
   - go test .
   - go vet .
   - go test ./...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] fix(manifest): return defensive metadata copies [iceberg-go]

Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #1544:
URL: https://github.com/apache/iceberg-go/pull/1544


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org