You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/25 17:31:08 UTC
[GitHub] leakingoxide opened a new pull request #6431: Add tooltips with
table's description to explore and table list views
leakingoxide opened a new pull request #6431: Add tooltips with table's description to explore and table list views
URL: https://github.com/apache/incubator-superset/pull/6431
This is a PR for https://github.com/apache/incubator-superset/issues/5922.
Preview:
I wasn't sure if we want to include info icon there, because
a) it doesn't currently involve react -> we'd have to include it or duplicate InfoTooltipWithTrigger in html/py
b) imo it'd clutter the view.
Of course can still add it if requested.
Long descriptions are automatically truncated by the tooltip here, but not in the explore view. Should I truncate them manually, or we're assuming it's user's responsibility to keep this short?
I also included info icon here:
although I'm not sure it's a good UX. I'd rather put it instead of "Click to edit the datasource", or merge those two texts together, but this is a decision that you're more qualified to make.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org