You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/02 10:09:05 UTC
[GitHub] [calcite] jinxing64 opened a new pull request #1294: [CALCITE-3167]
Remove redundant overriding methods of equals&hashcode in
EnumerableTableScan.java
jinxing64 opened a new pull request #1294: [CALCITE-3167] Remove redundant overriding methods of equals&hashcode in EnumerableTableScan.java
URL: https://github.com/apache/calcite/pull/1294
## What changes were proposed in this pull request?
In current code of EnumerableTableScan.java, methods of equals&hashCode are overrided for matching of EnumerableTableScans.
While after optimizing with the same HEP planner, EnumerableTableScans from two plans but with the same digest will the share the same Java object.
https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java#L192
I think it's ok to remove the redundant overriding methods in EnumerableTableScan.java
This is a minor change and I dig into this for the curiosity that EnumerableTableScan have the overriding methods but LogicalTableScan doesn't.
## How was this patch tested?
Tests added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services