You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Mark Hindess (JIRA)" <ji...@apache.org> on 2006/03/21 09:37:58 UTC

[jira] Created: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
--------------------------------------------------------------------

         Key: HARMONY-219
         URL: http://issues.apache.org/jira/browse/HARMONY-219
     Project: Harmony
        Type: Bug
  Components: Classlib  
    Reporter: Mark Hindess
    Priority: Trivial
 Attachments: SubjectDomainCombiner.NPE.diff

RI throws null pointer exception so should Harmony.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-219?page=all ]

Stepan Mishura reassigned HARMONY-219:
--------------------------------------

    Assign To: Stepan Mishura

> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff, fixHarmony219.txt
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-219?page=comments#action_12373526 ] 

Mark Hindess commented on HARMONY-219:
--------------------------------------

Looks good.  Thanks Stepan.

> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff, fixHarmony219.txt
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-219?page=all ]
     
Stepan Mishura closed HARMONY-219:
----------------------------------


Verified by Mark

> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff, fixHarmony219.txt
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-219?page=all ]

Stepan Mishura updated HARMONY-219:
-----------------------------------

    Attachment: fixHarmony219.txt

Mark, you are right - this is a bug. I reviewed your fix and test case. They looks good but some clean up is required.
I've attached a patch that incorporates your update and code clean up.

> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff, fixHarmony219.txt
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-219?page=all ]

Mark Hindess updated HARMONY-219:
---------------------------------

    Attachment: SubjectDomainCombiner.NPE.diff

This patch fixes the code and replaces the test case that was testing for incorrect behaviour.


> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug
>   Components: Classlib
>     Reporter: Mark Hindess
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-219) new javax.security.auth.SubjectDomainCombiner(null) should throw NPE

Posted by "Stepan Mishura (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-219?page=all ]
     
Stepan Mishura resolved HARMONY-219:
------------------------------------

    Resolution: Fixed

Thanks Mark,

I've incorporated your patch with code clean up and minor updates. The fix is applied to SECURITY module at repo revision 391912.

Please check that this fully resolves your problem.

> new javax.security.auth.SubjectDomainCombiner(null) should throw NPE
> --------------------------------------------------------------------
>
>          Key: HARMONY-219
>          URL: http://issues.apache.org/jira/browse/HARMONY-219
>      Project: Harmony
>         Type: Bug

>   Components: Classlib
>     Reporter: Mark Hindess
>     Assignee: Stepan Mishura
>     Priority: Trivial
>  Attachments: SubjectDomainCombiner.NPE.diff, fixHarmony219.txt
>
> RI throws null pointer exception so should Harmony.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira