You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eagle.apache.org by garrettlish <gi...@git.apache.org> on 2016/09/08 05:51:30 UTC

[GitHub] incubator-eagle pull request #423: EAGLE-531: Dedup alerts according to stat...

GitHub user garrettlish opened a pull request:

    https://github.com/apache/incubator-eagle/pull/423

    EAGLE-531: Dedup alerts according to state change

    <!--
    {% comment %}
    Licensed to the Apache Software Foundation (ASF) under one or more
    contributor license agreements.  See the NOTICE file distributed with
    this work for additional information regarding copyright ownership.
    The ASF licenses this file to you under the Apache License, Version 2.0
    (the "License"); you may not use this file except in compliance with
    the License.  You may obtain a copy of the License at
    
    http://www.apache.org/licenses/LICENSE-2.0
    
    Unless required by applicable law or agreed to in writing, software
    distributed under the License is distributed on an "AS IS" BASIS,
    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    See the License for the specific language governing permissions and
    limitations under the License.
    {% endcomment %}
    -->
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[EAGLE-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/garrettlish/incubator-eagle dedup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-eagle/pull/423.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #423
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #423: EAGLE-531: Dedup alerts according to stat...

Posted by garrettlish <gi...@git.apache.org>.
Github user garrettlish commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/423#discussion_r77951655
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/pom.xml ---
    @@ -291,6 +295,32 @@
                     <artifactId>commons-cli</artifactId>
                     <version>${common.cli.version}</version>
                 </dependency>
    +            <dependency>
    +            	<groupId>org.mongodb</groupId>
    +	            <artifactId>mongo-java-driver</artifactId>
    +	            <version>${mongodb.version}</version>
    +	        </dependency>
    +	        <dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-jaxrs</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    +			</dependency>
    +			<dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-xc</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    +			</dependency>
    +	        <dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-mapper-asl</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    --- End diff --
    
    sure, thx @haoch 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #423: EAGLE-531: Dedup alerts according to stat...

Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:

    https://github.com/apache/incubator-eagle/pull/423#discussion_r77950569
  
    --- Diff: eagle-core/eagle-alert-parent/eagle-alert/pom.xml ---
    @@ -291,6 +295,32 @@
                     <artifactId>commons-cli</artifactId>
                     <version>${common.cli.version}</version>
                 </dependency>
    +            <dependency>
    +            	<groupId>org.mongodb</groupId>
    +	            <artifactId>mongo-java-driver</artifactId>
    +	            <version>${mongodb.version}</version>
    +	        </dependency>
    +	        <dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-jaxrs</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    +			</dependency>
    +			<dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-xc</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    +			</dependency>
    +	        <dependency>
    +				<groupId>org.codehaus.jackson</groupId>
    +				<artifactId>jackson-mapper-asl</artifactId>
    +				<version>${codehaus-jackson.version}</version>
    --- End diff --
    
    Please try to use `fasterxml-jackson` instead of `codehaus-jackson` anytime if possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle issue #423: EAGLE-531: Dedup alerts according to state chang...

Posted by yonzhang <gi...@git.apache.org>.
Github user yonzhang commented on the issue:

    https://github.com/apache/incubator-eagle/pull/423
  
    @garrettlish can you please add more description to this PR and corresponding JIRA ticket EAGLE-531? This PR looks pretty important for people to learn alert deduplication.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-eagle pull request #423: EAGLE-531: Dedup alerts according to stat...

Posted by garrettlish <gi...@git.apache.org>.
Github user garrettlish closed the pull request at:

    https://github.com/apache/incubator-eagle/pull/423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---