[GitHub] [cordova-plugin-inappbrowser] NiklasMerz removed a comment on issue #534: Fix inappbrowser not opening on iOS 13 by using reusable window

[GitBox <gi...@apache.org>]

NiklasMerz removed a comment on issue #534: Fix inappbrowser not opening on iOS 13 by using reusable window
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/534#issuecomment-534577999
 
 
   Thank you @dpa99c for your great review.
   
   Regarding the hide issue that's something I forgot to test. In my last commit I moved the code with `tmpWindow.hidden = YES` to browser exit. This was necessary to catch the programmatic close from within the class CDVInAppBrowser and the close from CDVBrowserViewController which is called by the "done" button in the toolbar. So to fix this it should do to add this to hide or another fitting event. I will try.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org