You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2026/10/09 07:52:16 UTC
[GH] (rocketmq-dashboard/fix/nameserver-upgrade-field): Workflow run "CI" failed!
The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/nameserver-upgrade-field has failed.
Run started by GitHub user zjncs (triggered by zjncs).
Head commit for run:
24daa169e2a77aa331e1153f2cc2b82fc91876b2 / zjncs <18...@163.com>
fix(cluster): send targetVersion in the nameserver upgrade request
UpgradeNameServerDTO requires a non-blank targetVersion and the Java
service reads getTargetVersion(), but both frontend layers declared the
field as version - every caller following the type sent a body Jackson
silently stripped to nothing but clusterId/addr, and the request was
always rejected with 400 "targetVersion is required". Rename the field
through the api and service layers.
Closes #5619
Signed-off-by: zjncs <18...@163.com>
Review adjustments (lizhimins):
- Fix the third consumer the rename missed: cluster.test.ts's fixture
and upgradeNameServer call now send targetVersion, so tsc -b (run by
npm run build) is clean again.
- Fold the upgrade-contract case into the existing NameServer test in
cluster.test.ts instead of adding a fourth cluster test file; the
assertions run inside the mock reply handler, so the test starts with
expect.assertions(4).
- Drop the test-header note about UpdateNameServerDTO's missing newAddr
field and track it separately in #5776 instead.
- Restore trailing newlines on the touched files.
Report URL: https://github.com/apache/rocketmq-dashboard/actions/runs/37900561150
With regards,
GitHub Actions via GitBox