You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/02 13:21:43 UTC

[GitHub] [trafficserver] brbzull0 commented on a diff in pull request #8862: Deprecate TSSslSecretGet (not thread safe).

brbzull0 commented on code in PR #8862:
URL: https://github.com/apache/trafficserver/pull/8862#discussion_r887945392


##########
include/ts/ts.h:
##########
@@ -1304,6 +1304,8 @@ tsapi TSReturnCode TSSslServerCertUpdate(const char *cert_path, const char *key_
 
 /* Update the transient secret table for SSL_CTX loading */
 tsapi TSReturnCode TSSslSecretSet(const char *secret_name, int secret_name_length, const char *secret_data, int secret_data_len);
+/* NOTE:  TSSslSecretGet() is deprecated, it is not thread-safe.  It will be replaced with a thread-safe function
+** in Release 10 */

Review Comment:
   Shouldn't we use `TS_DEPRECATED` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org