You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by se...@apache.org on 2007/02/22 17:56:09 UTC
svn commit: r510587 - in
/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient:
HttpHost.java ProxyHost.java
Author: sebb
Date: Thu Feb 22 08:56:08 2007
New Revision: 510587
URL: http://svn.apache.org/viewvc?view=rev&rev=510587
Log:
Use super.clone() to ensure subclass clone() methods work
Modified:
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpHost.java
jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/ProxyHost.java
Modified: jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpHost.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpHost.java?view=diff&rev=510587&r1=510586&r2=510587
==============================================================================
--- jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpHost.java (original)
+++ jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/HttpHost.java Thu Feb 22 08:56:08 2007
@@ -114,16 +114,23 @@
*/
public HttpHost (final HttpHost httphost) {
super();
- this.hostname = httphost.hostname;
+ init(httphost);
+ }
+
+ private void init(final HttpHost httphost) {
+ this.hostname = httphost.hostname;
this.port = httphost.port;
this.protocol = httphost.protocol;
- }
+ }
/**
+ * @throws CloneNotSupportedException
* @see java.lang.Object#clone()
*/
- public Object clone() {
- return new HttpHost(this);
+ public Object clone() throws CloneNotSupportedException {
+ HttpHost copy = (HttpHost) super.clone();
+ copy.init(this);
+ return copy;
}
/**
Modified: jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/ProxyHost.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/ProxyHost.java?view=diff&rev=510587&r1=510586&r2=510587
==============================================================================
--- jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/ProxyHost.java (original)
+++ jakarta/commons/proper/httpclient/trunk/src/java/org/apache/commons/httpclient/ProxyHost.java Thu Feb 22 08:56:08 2007
@@ -74,10 +74,12 @@
}
/**
+ * @throws CloneNotSupportedException
* @see java.lang.Object#clone()
*/
- public Object clone() {
- return new ProxyHost(this);
+ public Object clone() throws CloneNotSupportedException {
+ ProxyHost copy = (ProxyHost) super.clone();
+ return copy;
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org