[GitHub] [spark] cloud-fan commented on a change in pull request #34388: [SPARK-37115][SQL] HiveClientImple use shim to wrap all hive client calls

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #34388:
URL: https://github.com/apache/spark/pull/34388#discussion_r736515376



##########
File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -97,12 +116,50 @@ private[client] sealed abstract class Shim {
 
   def alterPartitions(hive: Hive, tableName: String, newParts: JList[Partition]): Unit
 
+  def createTable(hive: Hive, table: Table, ifNotExists: Boolean): Unit
+
+  def getTable(
+      hive: Hive,
+      dbName: String,
+      tableName: String,
+      throwException: Boolean = true): Table
+
   def getTablesByType(
       hive: Hive,
       dbName: String,
       pattern: String,
       tableType: TableType): Seq[String]
 
+  def getTablesByPattern(hive: Hive, dbName: String, pattern: String): JList[String]
+
+  def getAllTables(hive: Hive, dbName: String): JList[String]
+
+  def dropTable(hive: Hive, dbName: String, tableName: String): Unit
+
+  def getPartition(
+      hive: Hive,
+      table: Table,
+      partSpec: JMap[String, String],
+      forceCreate: Boolean): Partition
+
+  def getPartitions(
+      hive: Hive,
+      table: Table,
+      partSpec: JMap[String, String]): JList[Partition]
+
+  def getPartitionNames(
+    hive: Hive,
+    dbName: String,
+    tblName: String,
+    max: Short): JList[String]

Review comment:
       ### 
   ```suggestion
        hive: Hive,
        dbName: String,
        tblName: String,
        max: Short): JList[String]
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org