[GitHub] vdiravka commented on a change in pull request #1539: DRILL-6847 Add Query Metadata to RESTful Interface

[GitBox <gi...@apache.org>]

vdiravka commented on a change in pull request #1539: DRILL-6847 Add Query Metadata to RESTful Interface
URL: https://github.com/apache/drill/pull/1539#discussion_r233279433
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebUserConnection.java
 ##########
 @@ -64,6 +66,8 @@
 
   public final Set<String> columns = Sets.newLinkedHashSet();
 
+  public final ArrayList<String> metadata = Lists.newArrayList();
 
 Review comment:
   Guava suggests to use the ArrayList constructor directly, taking advantage of the new "diamond" syntax:
   https://google.github.io/guava/releases/23.0/api/docs/com/google/common/collect/Lists.html
   Thus `public final List<String> metadata = new ArrayList<>();` will be better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services