You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajitha R <ra...@gmail.com> on 2017/06/27 11:05:40 UTC

Review Request 60461: Virtual fact minor fixes [LENS-1440, LENS-1446, LENS-1447]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60461/
-----------------------------------------------------------

Review request for lens and Rajat Khandelwal.


Repository: lens


Description
-------

1. Update command fix for virtual fact
2. latest date od cube fix
3. optimization in virtual fact


Diffs
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 5c05e53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java c6ef6d2 


Diff: https://reviews.apache.org/r/60461/diff/1/


Testing
-------


Thanks,

Rajitha R


Re: Review Request 60461: Virtual fact minor fixes [LENS-1440, LENS-1446, LENS-1447]

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60461/#review179087
-----------------------------------------------------------


Ship it!




Ship It!

- Rajat Khandelwal


On June 27, 2017, 7:54 p.m., Rajitha R wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60461/
> -----------------------------------------------------------
> 
> (Updated June 27, 2017, 7:54 p.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 1. Update command fix for virtual fact
> 2. latest date od cube fix
> 3. optimization in virtual fact
> 
> 
> Diffs
> -----
> 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 5c05e53 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java c6ef6d2 
> 
> 
> Diff: https://reviews.apache.org/r/60461/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajitha R
> 
>


Re: Review Request 60461: Virtual fact minor fixes [LENS-1440, LENS-1446, LENS-1447]

Posted by Rajitha R <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60461/
-----------------------------------------------------------

(Updated June 27, 2017, 2:24 p.m.)


Review request for lens and Rajat Khandelwal.


Changes
-------

checkstyle fix


Repository: lens


Description
-------

1. Update command fix for virtual fact
2. latest date od cube fix
3. optimization in virtual fact


Diffs (updated)
-----

  lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java aca1cf9 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 5c05e53 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java c6ef6d2 


Diff: https://reviews.apache.org/r/60461/diff/2/

Changes: https://reviews.apache.org/r/60461/diff/1-2/


Testing
-------


Thanks,

Rajitha R