Re: svn commit: r713467 - in /hadoop/hbase/branches/0.18: ./ src/java/org/apache/hadoop/hbase/ src/java/org/apache/hadoop/hbase/master/ src/java/org/apache/hadoop/hbase/regionserver/

[stack <st...@duboce.net>]

jimk@apache.org wrote:
> Author: jimk
> Date: Wed Nov 12 11:30:04 2008
> New Revision: 713467
>
> URL: http://svn.apache.org/viewvc?rev=713467&view=rev
> Log:
> HBASE-602   HBase Crash when network card has a IPv6 address
>
> Modified:
>     hadoop/hbase/branches/0.18/CHANGES.txt
>     hadoop/hbase/branches/0.18/src/java/org/apache/hadoop/hbase/HServerAddress.java
>     hadoop/hbase/branches/0.18/src/java/org/apache/hadoop/hbase/master/ProcessServerShutdown.java
>     hadoop/hbase/branches/0.18/src/java/org/apache/hadoop/hbase/regionserver/HLog.java
>     hadoop/hbase/branches/0.18/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
>
> ...
> +  /**
> +   * Construct the HLog directory name
> +   * 
> +   * @param info HServerInfo for server
> +   * @return the HLog directory name
> +   */
> +  public static String getHLogDirectoryName(HServerInfo info) {
> +    StringBuilder dirName = new StringBuilder("log_");
> +    dirName.append(info.getServerAddress().getBindAddress().replaceAll(":", "."));
> +    dirName.append("_");
> +    dirName.append(info.getStartCode());
> +    dirName.append("_");
> +    dirName.append(info.getServerAddress().getPort());
> +    return dirName.toString();
> +  }
Would uriencoding server address make the above more robust rather than 
doing replace of ':'?
St.Ack