You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@manifoldcf.apache.org by "Furkan KAMACI (JIRA)" <ji...@apache.org> on 2016/08/14 11:06:22 UTC

[jira] [Commented] (CONNECTORS-1304) ban usage of String.toUpperCase() without Locale

    [ https://issues.apache.org/jira/browse/CONNECTORS-1304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420293#comment-15420293 ] 

Furkan KAMACI commented on CONNECTORS-1304:
-------------------------------------------

[~iorixxx], [~kwright@metacarta.com] I've integrated [forbidden calls|https://github.com/policeman-tools/forbidden-apis/wiki] check via CONNECTORS-1332 which covers also other stuff than using String.toUpperCase() without Locale. So, we can mark this issue as resolved.

> ban usage of String.toUpperCase() without Locale
> ------------------------------------------------
>
>                 Key: CONNECTORS-1304
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1304
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: SearchBlox connector
>    Affects Versions: ManifoldCF 2.4
>            Reporter: Ahmet Arslan
>            Assignee: Ahmet Arslan
>             Fix For: ManifoldCF next
>
>
> When relied on the default Locale, toUpperCase() is not reliable. For example: In SearchBloxConnector.java, "title_boost".toUpperCase() will yield {{TİTLE_BOOST}} on Turkish Locale and won't match {{TITLE_BOOST}}. We should prevent this in a more permanent way. I would like to integrate Uwe's [forbidden apis|https://github.com/policeman-tools/forbidden-apis] when I have time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)