You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2024/12/12 14:22:17 UTC

[I] Re-add OsgiServletRegisterer [camel-karaf]

jbonofre opened a new issue, #562:
URL: https://github.com/apache/camel-karaf/issues/562

   When camel-karaf upgraded to camel 4.x, `OsgiServletRegisterer` has been lost, mostly because it was not compliant with latest OSGi compendium spec (especially `org.osgi.service.http.HttpService`).
   
   As camel-karaf 4.x supports Karaf 4.4.x (and 4.5.x soon), it makes sense to base on the Pax Web `HttpService` from this base.
   
   I will re-add `OsgiServletRegisterer` in camel-karaf (probably in a dedicated bundle).
   
   This will allow to support REST DSL in Blueprint (like this [camel-karaf-examples/examples/camel-example-servlet-rest-blueprint/src/main/resources/OSGI-INF/blueprint/camel.xml at main ยท apache/camel-karaf-examples](https://github.com/apache/camel-karaf-examples/blob/main/examples/camel-example-servlet-rest-blueprint/src/main/resources/OSGI-INF/blueprint/camel.xml)).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "joef551 (via GitHub)" <gi...@apache.org>.
joef551 commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-4133944795

   In camel-karaf 4.14.5 you have re-added the OsgiServletRegisterer; unfortunately, this does not support the REST DSL in the Blueprint example that you posted. This is because org.apache.camel.component.servlet.CamelHttpTransportServlet  is jakarta.servlet compliant but org.osgi.service.http.HttpService and OsgiServletRegisterer are not. Camel 4.x is only jakarta compliant and Karaf 4.4.x is not fully jakarta compliant; therefore, you cannot reliably mix the two. Hopefully, this will all get resolved with Karaf 4.5 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "lichtin (via GitHub)" <gi...@apache.org>.
lichtin commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-2963433153

   Yes of course. However, what I am saying is that whoever decided to remove it should please reconsider this decision. 
   Using open-source often means that one is at the mercy of a _maintainer_ who can decide to remove code and functionality.
   Typically this is handled by offering a migration path (see Camel Migration docs), but here it seems this is not the case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre closed issue #562: Re-add OsgiServletRegisterer
URL: https://github.com/apache/camel-karaf/issues/562


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "joef-argo (via GitHub)" <gi...@apache.org>.
joef-argo commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-2628363284

   Is OsgiServletRegisterer supposed to be in 4.9.0? I installed 4.9.0 into Karaf 4.4.7 and started the camel-servlet feature, but OsgiServletRegisterer is not being exported. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "lichtin (via GitHub)" <gi...@apache.org>.
lichtin commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-2963222980

   It's quite a showstopper to no longer have OsgiServletRegisterer available. 
   Is it not possible to re-add it, even if later there is another solution?
   Right now I'm stuck and can't upgrade to newer Camel and Karaf versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "joef-argo (via GitHub)" <gi...@apache.org>.
joef-argo commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-2964085728

   Re https://github.com/apache/camel-karaf/pull/563 - It states user experience should be the same. Can someone please expand on this? How do I need to refactor my blueprint routes? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Re-add OsgiServletRegisterer [camel-karaf]

Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on issue #562:
URL: https://github.com/apache/camel-karaf/issues/562#issuecomment-2963387343

   Hi, if it's a showstopper for you, it's an open-source project, so please don't hesitate to propose a pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org