You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/31 15:47:41 UTC
[GitHub] [beam] lukecwik edited a comment on issue #11263: [BEAM-9325]
Override proper write method in UnownedOutputStream
lukecwik edited a comment on issue #11263: [BEAM-9325] Override proper write method in UnownedOutputStream
URL: https://github.com/apache/beam/pull/11263#issuecomment-606705998
What a terrible choice for the FilterOutputStream implementation. Reading the javadoc they clearly state that everyone who subclasses it needs to provide the optimal `write(byte[], int, int)` method. Also double checked grepcode for the source and they write one byte at a time.
I was unaware of the FilterOutputStream problem when writing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services