You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:20:39 UTC
[GitHub] [celix] pnoltes opened a new pull request #350: Feature/use async api for rsa
pnoltes opened a new pull request #350:
URL: https://github.com/apache/celix/pull/350
This PR mainly updates some setup calls in C remote service to use the Celix async API to prevent deadlocks.
Also
- updates C RSA and topology manager test from CPPUTEST to gtest and adds some needed Celix event thread sync calls.
- Fixes an issue in creating async service tracker with a filter, where the filter was not copied and could be invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] pnoltes merged pull request #350: Feature/use async api for rsa
Posted by GitBox <gi...@apache.org>.
pnoltes merged pull request #350:
URL: https://github.com/apache/celix/pull/350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [celix] codecov-commenter commented on pull request #350: Feature/use async api for rsa
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #350:
URL: https://github.com/apache/celix/pull/350#issuecomment-859301204
# [Codecov](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#350](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (065deec) into [master](https://codecov.io/gh/apache/celix/commit/0cd23ad37ccb238f82a002321de4e396f08b2f85?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cd23ad) will **increase** coverage by `1.06%`.
> The diff coverage is `97.55%`.
[](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
+ Coverage 71.40% 72.46% +1.06%
==========================================
Files 199 201 +2
Lines 35262 36929 +1667
==========================================
+ Hits 25178 26762 +1584
- Misses 10084 10167 +83
```
| [Impacted Files](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libs/framework/src/bundle\_context.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlicy9mcmFtZXdvcmsvc3JjL2J1bmRsZV9jb250ZXh0LmM=) | `76.99% <82.35%> (+0.40%)` | :arrow_up: |
| [...te\_service\_admin\_dfi/src/export\_registration\_dfi.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9leHBvcnRfcmVnaXN0cmF0aW9uX2RmaS5j) | `80.76% <91.30%> (-0.62%)` | :arrow_down: |
| [...te\_service\_admin\_dfi/src/import\_registration\_dfi.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9pbXBvcnRfcmVnaXN0cmF0aW9uX2RmaS5j) | `74.14% <98.21%> (-1.74%)` | :arrow_down: |
| [...ice\_admin\_dfi/src/remote\_service\_admin\_activator.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9yZW1vdGVfc2VydmljZV9hZG1pbl9hY3RpdmF0b3IuYw==) | `100.00% <100.00%> (+4.00%)` | :arrow_up: |
| [...e\_service\_admin\_dfi/src/remote\_service\_admin\_dfi.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvcmVtb3RlX3NlcnZpY2VfYWRtaW5fZGZpL3NyYy9yZW1vdGVfc2VydmljZV9hZG1pbl9kZmkuYw==) | `83.43% <100.00%> (-0.07%)` | :arrow_down: |
| [...s/remote\_services/topology\_manager/src/activator.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvdG9wb2xvZ3lfbWFuYWdlci9zcmMvYWN0aXZhdG9yLmM=) | `93.16% <100.00%> (ø)` | |
| [...te\_services/topology\_manager/tms\_tst/tms\_tests.cpp](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvdG9wb2xvZ3lfbWFuYWdlci90bXNfdHN0L3Rtc190ZXN0cy5jcHA=) | `98.89% <100.00%> (+0.03%)` | :arrow_up: |
| [...e\_services/topology\_manager/src/topology\_manager.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9yZW1vdGVfc2VydmljZXMvdG9wb2xvZ3lfbWFuYWdlci9zcmMvdG9wb2xvZ3lfbWFuYWdlci5j) | `83.36% <0.00%> (-2.67%)` | :arrow_down: |
| [...les/pubsub/pubsub\_admin\_tcp/v2/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3RjcC92Mi9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <0.00%> (ø)` | |
| [...les/pubsub/pubsub\_admin\_zmq/v2/src/psa\_activator.c](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVuZGxlcy9wdWJzdWIvcHVic3ViX2FkbWluX3ptcS92Mi9zcmMvcHNhX2FjdGl2YXRvci5j) | `100.00% <0.00%> (ø)` | |
| ... and [27 more](https://codecov.io/gh/apache/celix/pull/350/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0cd23ad...065deec](https://codecov.io/gh/apache/celix/pull/350?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org