Fix in Maven POM.xml - simpleddr

[Ankur Kumar <an...@hotmail.com>]

Hi All,
I was trying to build locally and it failed because of missing entry in pom.xml of simpleddr:http://svn.apache.org/repos/asf/incubator/devicemap/trunk/devicemap/java/simpleddr/pom.xml
I have fixed the same and attaching the patch file to be applied by committer:               <dependency> 			<groupId>org.apache.devicemap</groupId> 			<artifactId>devicemap-test-data</artifactId>+			<version>1.0.1-SNAPSHOT</version> 			<scope>test</scope> 		</dependency>
Please review and commit.
Thanks,
Ankur Kumar
 		 	   		  

Re: Fix in Maven POM.xml - simpleddr

[Werner Keil <we...@gmail.com>]

I saw the umbrella POM of the Java projects has an outdated test-data
version:
<devicemap.testdata.version>1.0.0</devicemap.testdata.version>
will change it there, the right place to do, but why didn't Jenkins flag
that by throwing an error??

Is there some repository the 1.0.0 versions are deployed to after all?[?]
test-data was tagged once, but not officially released, that's left to a
DDR release, sice the other clients do not use it in their unit tests, so
it could not have been released as.

Werner

On Thu, Jul 31, 2014 at 3:52 PM, Werner Keil <we...@gmail.com> wrote:

> The "Reactor" POM calls them in the right order, and artifacts like
> test-data are temporarily deployed:
>
> [INFO] Installing /home/jenkins/jenkins-slave/workspace/devicemap-java6/trunk/data/test-data/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/devicemap/devicemap-test-data/1.0.1-SNAPSHOT/devicemap-test-data-1.0.1-SNAPSHOT.pom
>
>
> but I doubt the next Jenkins job picks them up if they were unchanged, so
> calling the same locally as Jenkins should work.
>
> Ultimately we should ensure, released artifacts aren't just on the
> download page http://incubator.apache.org/devicemap/download/ but Maven
> repositories, at least that by Apache.
>
> Werner
>
> On Thu, Jul 31, 2014 at 3:42 PM, Werner Keil <we...@gmail.com>
> wrote:
>
>> Did you try the same as the public Jenkins build?[?]
>> AFAIK that does not do any caching or store things in local repo, so why
>> isn't the Jenkins build broken?
>>
>> Werner
>>
>>
>> On Thu, Jul 31, 2014 at 3:37 PM, Bertrand Delacretaz <
>> bdelacretaz@apache.org> wrote:
>>
>>> On Thu, Jul 31, 2014 at 3:31 PM, Werner Keil <we...@gmail.com>
>>> wrote:
>>> > ...you must check out
>>> > the entire "java" hierarchy and build the parent POM at least once...
>>>
>>> I tried that from the top level of a
>>> https://svn.apache.org/repos/asf/incubator/devicemap/trunk checkout
>>> and it didn't work for me, starting with an empty local Maven
>>> repository, see below.
>>>
>>> I would suggest changing that dependency to a snapshot for now, so
>>> that the build is self-contained and tests the latest stuff.
>>>
>>> $ rm -rf ~/.m2/repository/org/apache/devicemap/
>>> $ mvn clean install
>>>
>>> [ERROR] Failed to execute goal on project devicemap-simpleddr: Could
>>> not resolve dependencies for project
>>> org.apache.devicemap:devicemap-simpleddr:jar:1.0.0: Could not find
>>> artifact org.apache.devicemap:devicemap-test-data:jar:1.0.0 in central
>>> (http://repo.maven.apache.org/maven2) -> [Help 1]
>>>
>>> -Bertrand
>>>
>>
>>
>

Re: Fix in Maven POM.xml - simpleddr

[Werner Keil <we...@gmail.com>]

The "Reactor" POM calls them in the right order, and artifacts like
test-data are temporarily deployed:

[INFO] Installing
/home/jenkins/jenkins-slave/workspace/devicemap-java6/trunk/data/test-data/pom.xml
to /home/jenkins/jenkins-slave/maven-repositories/0/org/apache/devicemap/devicemap-test-data/1.0.1-SNAPSHOT/devicemap-test-data-1.0.1-SNAPSHOT.pom


but I doubt the next Jenkins job picks them up if they were unchanged, so
calling the same locally as Jenkins should work.

Ultimately we should ensure, released artifacts aren't just on the download
page http://incubator.apache.org/devicemap/download/ but Maven
repositories, at least that by Apache.

Werner

On Thu, Jul 31, 2014 at 3:42 PM, Werner Keil <we...@gmail.com> wrote:

> Did you try the same as the public Jenkins build?[?]
> AFAIK that does not do any caching or store things in local repo, so why
> isn't the Jenkins build broken?
>
> Werner
>
>
> On Thu, Jul 31, 2014 at 3:37 PM, Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> On Thu, Jul 31, 2014 at 3:31 PM, Werner Keil <we...@gmail.com>
>> wrote:
>> > ...you must check out
>> > the entire "java" hierarchy and build the parent POM at least once...
>>
>> I tried that from the top level of a
>> https://svn.apache.org/repos/asf/incubator/devicemap/trunk checkout
>> and it didn't work for me, starting with an empty local Maven
>> repository, see below.
>>
>> I would suggest changing that dependency to a snapshot for now, so
>> that the build is self-contained and tests the latest stuff.
>>
>> $ rm -rf ~/.m2/repository/org/apache/devicemap/
>> $ mvn clean install
>>
>> [ERROR] Failed to execute goal on project devicemap-simpleddr: Could
>> not resolve dependencies for project
>> org.apache.devicemap:devicemap-simpleddr:jar:1.0.0: Could not find
>> artifact org.apache.devicemap:devicemap-test-data:jar:1.0.0 in central
>> (http://repo.maven.apache.org/maven2) -> [Help 1]
>>
>> -Bertrand
>>
>
>

Re: Fix in Maven POM.xml - simpleddr

[Werner Keil <we...@gmail.com>]

Did you try the same as the public Jenkins build?[?]
AFAIK that does not do any caching or store things in local repo, so why
isn't the Jenkins build broken?

Werner

On Thu, Jul 31, 2014 at 3:37 PM, Bertrand Delacretaz <bdelacretaz@apache.org
> wrote:

> On Thu, Jul 31, 2014 at 3:31 PM, Werner Keil <we...@gmail.com>
> wrote:
> > ...you must check out
> > the entire "java" hierarchy and build the parent POM at least once...
>
> I tried that from the top level of a
> https://svn.apache.org/repos/asf/incubator/devicemap/trunk checkout
> and it didn't work for me, starting with an empty local Maven
> repository, see below.
>
> I would suggest changing that dependency to a snapshot for now, so
> that the build is self-contained and tests the latest stuff.
>
> $ rm -rf ~/.m2/repository/org/apache/devicemap/
> $ mvn clean install
>
> [ERROR] Failed to execute goal on project devicemap-simpleddr: Could
> not resolve dependencies for project
> org.apache.devicemap:devicemap-simpleddr:jar:1.0.0: Could not find
> artifact org.apache.devicemap:devicemap-test-data:jar:1.0.0 in central
> (http://repo.maven.apache.org/maven2) -> [Help 1]
>
> -Bertrand
>

Re: Fix in Maven POM.xml - simpleddr

[Bertrand Delacretaz <bd...@apache.org>]

On Thu, Jul 31, 2014 at 3:31 PM, Werner Keil <we...@gmail.com> wrote:
> ...you must check out
> the entire "java" hierarchy and build the parent POM at least once...

I tried that from the top level of a
https://svn.apache.org/repos/asf/incubator/devicemap/trunk checkout
and it didn't work for me, starting with an empty local Maven
repository, see below.

I would suggest changing that dependency to a snapshot for now, so
that the build is self-contained and tests the latest stuff.

$ rm -rf ~/.m2/repository/org/apache/devicemap/
$ mvn clean install

[ERROR] Failed to execute goal on project devicemap-simpleddr: Could
not resolve dependencies for project
org.apache.devicemap:devicemap-simpleddr:jar:1.0.0: Could not find
artifact org.apache.devicemap:devicemap-test-data:jar:1.0.0 in central
(http://repo.maven.apache.org/maven2) -> [Help 1]

-Bertrand

Re: Fix in Maven POM.xml - simpleddr

[Werner Keil <we...@gmail.com>]

Hi,

No, that's not missing, you seem to not have built it from a "parent"
level, see https://builds.apache.org/job/devicemap-java6/ which builds fine.

While none of the Maven artifacts are on a public repo, you must check out
the entire "java" hierarchy and build the parent POM at least once.
If the parent pom where dependencyManagement is maintained, was available
on MavenCentral, you would get that. We are aware of the MavenCentral
problem and working on a solution, at least following the official release
of certain components.

Looking at bigger projects including the often quoted Sling, this is done
very consequently. And e.g. a dependency like "device-data" or "test-data"
which is used everywhere does not need to be fixed in 100 places (including
every single example project, etc.)

Aside from a few cases like java-client (which is called from the parent
but uses "apache-parent" POM where project specific properties are
naturally not available) most others do use that.
And it's a good practice among Apache projects.

If you need further information related to Maven, please check out
http://maven.apache.org/

Regards,
Werner

On Thu, Jul 31, 2014 at 3:08 PM, Ankur Kumar <an...@hotmail.com> wrote:

> Hi All,
>
> I was trying to build locally and it failed because of missing entry in
> pom.xml of simpleddr:
>
> http://svn.apache.org/repos/asf/incubator/devicemap/trunk/devicemap/java/simpleddr/pom.xml
>
> I have fixed the same and attaching the patch file to be applied by
> committer:
>                <dependency>
>   <groupId>org.apache.devicemap</groupId>
>   <artifactId>devicemap-test-data</artifactId>
> + <version>1.0.1-SNAPSHOT</version>
>   <scope>test</scope>
>   </dependency>
>
> Please review and commit.
>
> Thanks,
>
> Ankur Kumar
>
>