You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/04/25 23:41:03 UTC

[jira] [Created] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

DatacenterReadResolver not triggering repair
--------------------------------------------

                 Key: CASSANDRA-2556
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
             Project: Cassandra
          Issue Type: Bug
            Reporter: Stu Hood
             Fix For: 0.8.0


DatacenterReadResolver only calls maybeResolveForRepair for messages received locally.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2556:
--------------------------------------

             Reviewer: slebresne
          Component/s: Core
             Priority: Minor  (was: Major)
    Affects Version/s: 0.7.0
        Fix Version/s:     (was: 0.8.0)
                       0.7.6
             Assignee: Jonathan Ellis

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026265#comment-13026265 ] 

Sylvain Lebresne commented on CASSANDRA-2556:
---------------------------------------------

+1
The patch applies on top of 0.8 (that is on top of CASSANDRA-2552 v2 for 0.8). Should be backported to 0.7 first I think.

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-2556:
--------------------------------------

    Attachment: 2556.txt

patch that extracts the "is this message one that should count towards blockfor" logic into the waitingFor method; DatacenterReadCallback now only overrides those instead of all of the response methods, which fixes the bug and reduces the surface for introducing similar bugs in the future.  (applies on top of CASSANDRA-2552 v2.)

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-2556.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8.0

committed

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6, 0.8.0
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032432#comment-13032432 ] 

Jonathan Ellis commented on CASSANDRA-2556:
-------------------------------------------

This also fixed a second bug: the old code checked for n == blockFor on LOCAL_QUORUM, so there was a race where if we exceeded blockFor with two responses coming in at nearly the same time, it would never test at the moment of equality and the coordinator would throw TOE even though enough responses were actually received.

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6, 0.8.0 beta 2
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stu Hood updated CASSANDRA-2556:
--------------------------------

    Description: DatacenterReadResolver only calls maybeResolveForRepair for local reads.  (was: DatacenterReadResolver only calls maybeResolveForRepair for messages received locally.)

> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Stu Hood
>             Fix For: 0.8.0
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CASSANDRA-2556) DatacenterReadResolver not triggering repair

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026310#comment-13026310 ] 

Hudson commented on CASSANDRA-2556:
-----------------------------------

Integrated in Cassandra-0.7 #460 (See [https://builds.apache.org/hudson/job/Cassandra-0.7/460/])
    trigger read repair correctly forLOCAL_QUORUM reads
patch by jbellis; reviewed by slebresne for CASSANDRA-2556


> DatacenterReadResolver not triggering repair
> --------------------------------------------
>
>                 Key: CASSANDRA-2556
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2556
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.7.0
>            Reporter: Stu Hood
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 0.7.6, 0.8.0
>
>         Attachments: 2556.txt
>
>
> DatacenterReadResolver only calls maybeResolveForRepair for local reads.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira