You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by GitBox <gi...@apache.org> on 2022/04/11 16:07:00 UTC

[GitHub] [poi] vladmashk opened a new pull request, #323: Make XSSFSheet's getRows(int, int, boolean) public instead of private

vladmashk opened a new pull request, #323:
URL: https://github.com/apache/poi/pull/323

   It is a very useful method and it would be nice if we could use it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] pjfanning commented on pull request #323: Make XSSFSheet's getRows(int, int, boolean) public instead of private

Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #323:
URL: https://github.com/apache/poi/pull/323#issuecomment-1095400100

   @vladmashk thanks. I'm neutral about this change. If you were to add some tests, then I'd be a bit more supportive.
   This is easily implemented inside your own code as opposed to us bloating the API with more methods that need support and tests - but if this PR had tests, then maybe. We have no releases planned for a while btw.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[GitHub] [poi] vladmashk closed pull request #323: Make XSSFSheet's getRows(int, int, boolean) public instead of private

Posted by GitBox <gi...@apache.org>.
vladmashk closed pull request #323: Make XSSFSheet's getRows(int, int, boolean) public instead of private
URL: https://github.com/apache/poi/pull/323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org