You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/05/17 21:29:35 UTC
[GitHub] [beam] chamikaramj opened a new pull request, #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
chamikaramj opened a new pull request, #17696:
URL: https://github.com/apache/beam/pull/17696
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
ihji commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r881279584
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
+ return new PythonMap<>(pythonFunction, outputCoder, PYTHON_MAP_FN_TRANSFORM);
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaFlatMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
+ return new PythonMap<>(pythonFunction, outputCoder, PYTHON_FLATMAP_FN_TRANSFORM);
+ }
+
+ public PythonMap<InputT, OutputT> withExpansionService(String expansionService) {
+ this.expansionService = expansionService;
+ return this;
+ }
+
+ @Override
+ public PCollection<OutputT> expand(PCollection<? extends InputT> input) {
+ PythonExternalTransform<PCollection<? extends InputT>, PCollection<OutputT>> pythonMapElements =
+ (expansionService == null)
Review Comment:
FYI, we don't need a ternary operation with null check if we use an empty string as a default value for `expansionService`.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -191,6 +196,23 @@ public PythonExternalTransform<InputT, OutputT> withTypeHint(
return this;
}
+ public PythonExternalTransform<InputT, OutputT> withOutputCoders(
+ Map<String, Coder<?>> outputCoders) {
+ if (this.outputCoders.size() > 0) {
+ throw new IllegalArgumentException("Output coders were already specified");
+ }
+ this.outputCoders.putAll(outputCoders);
+ return this;
+ }
+
+ public PythonExternalTransform<InputT, OutputT> withOutputCoder(Coder<?> outputCoder) {
Review Comment:
ditto
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -191,6 +196,23 @@ public PythonExternalTransform<InputT, OutputT> withTypeHint(
return this;
}
+ public PythonExternalTransform<InputT, OutputT> withOutputCoders(
Review Comment:
Do we need a documentation since it's a public method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r882117830
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
Ah, I was hoping inference would kick in. Should not be a blocker for now. (Interestingly, PickleCoder could be fine for adjacent transforms, as long as the output is interpretable, but that can be deferred to future work.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1137902071
Run XVR_JavaUsingPython_Dataflow PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1137839650
Run XVR_JavaUsingPython_Dataflow PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1136553670
Run XVR_JavaUsingPython_Dataflow PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1136481440
Run XVR_Direct PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r881915006
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -72,6 +73,9 @@
private @Nullable Object @NonNull [] argsArray;
private @Nullable Row providedKwargsRow;
+ Map<String, Coder<?>> outputCoders;
+ private static final String PYTHON_MAIN_OUTPUT_KEY = "0";
Review Comment:
I'm wary of hard-coding this--what if it changes? If there is one and only one output, should we be insensitive to the name?
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
Is it possible for outputCoder to be optional (if it can be inferred)?
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
Is there value in the (presumably end-user) constructing a PythonCallableSource vs. just accepting a String here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1142516077
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1142515785
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1129346039
Run XVR_Direct PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1129364086
# [Codecov](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17696](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f815444) into [master](https://codecov.io/gh/apache/beam/commit/03c3c3657ea51a60e301a25eef70d006fe8cc0e2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03c3c36) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #17696 +/- ##
==========================================
- Coverage 74.00% 73.99% -0.02%
==========================================
Files 695 695
Lines 91798 91798
==========================================
- Hits 67939 67928 -11
- Misses 22611 22622 +11
Partials 1248 1248
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.74% <ø> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `89.20% <0.00%> (-1.44%)` | :arrow_down: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `92.44% <0.00%> (-0.65%)` | :arrow_down: |
| [sdks/python/apache\_beam/runners/direct/executor.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvZXhlY3V0b3IucHk=) | `96.46% <0.00%> (-0.55%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.55% <0.00%> (-0.13%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/typecoders.py](https://codecov.io/gh/apache/beam/pull/17696/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3R5cGVjb2RlcnMucHk=) | `93.67% <0.00%> (+1.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [03c3c36...f815444](https://codecov.io/gh/apache/beam/pull/17696?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] robertwb commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
robertwb commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r882116881
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1137939966
Run XVR_JavaUsingPython_Dataflow PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1129334993
R: @ihji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1136553978
@ihji PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r881987405
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
+ return new PythonMap<>(pythonFunction, outputCoder, PYTHON_MAP_FN_TRANSFORM);
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaFlatMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
+ return new PythonMap<>(pythonFunction, outputCoder, PYTHON_FLATMAP_FN_TRANSFORM);
+ }
+
+ public PythonMap<InputT, OutputT> withExpansionService(String expansionService) {
+ this.expansionService = expansionService;
+ return this;
+ }
+
+ @Override
+ public PCollection<OutputT> expand(PCollection<? extends InputT> input) {
+ PythonExternalTransform<PCollection<? extends InputT>, PCollection<OutputT>> pythonMapElements =
+ (expansionService == null)
Review Comment:
Updated.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -191,6 +196,23 @@ public PythonExternalTransform<InputT, OutputT> withTypeHint(
return this;
}
+ public PythonExternalTransform<InputT, OutputT> withOutputCoders(
+ Map<String, Coder<?>> outputCoders) {
+ if (this.outputCoders.size() > 0) {
+ throw new IllegalArgumentException("Output coders were already specified");
+ }
+ this.outputCoders.putAll(outputCoders);
+ return this;
+ }
+
+ public PythonExternalTransform<InputT, OutputT> withOutputCoder(Coder<?> outputCoder) {
Review Comment:
Done.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -191,6 +196,23 @@ public PythonExternalTransform<InputT, OutputT> withTypeHint(
return this;
}
+ public PythonExternalTransform<InputT, OutputT> withOutputCoders(
Review Comment:
Done.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
I think it makes sense to simplify this to String for now. We can add an overloaded methods for PythonCallableSource later of needed.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
Unfortunately Python Map/FlatMap transforms end up using PickleCoder by default when a coder hint is not provided. So we have to provide a coder hint for the expansion to not break. We could use StringUTF8Coder or RowCoder (with a user provided Schema) as the default but none of these options seems to be good either.
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/PythonExternalTransform.java:
##########
@@ -72,6 +73,9 @@
private @Nullable Object @NonNull [] argsArray;
private @Nullable Row providedKwargsRow;
+ Map<String, Coder<?>> outputCoders;
+ private static final String PYTHON_MAIN_OUTPUT_KEY = "0";
Review Comment:
I don't think the key we use here matters when using for a single output. Changed to a different string and added a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1139099844
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1139099206
PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1129501564
Run XVR_Direct PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj merged PR #17696:
URL: https://github.com/apache/beam/pull/17696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ihji commented on a diff in pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
ihji commented on code in PR #17696:
URL: https://github.com/apache/beam/pull/17696#discussion_r881952432
##########
sdks/java/extensions/python/src/main/java/org/apache/beam/sdk/extensions/python/transforms/PythonMap.java:
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.python.transforms;
+
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.extensions.python.PythonExternalTransform;
+import org.apache.beam.sdk.transforms.PTransform;
+import org.apache.beam.sdk.util.PythonCallableSource;
+import org.apache.beam.sdk.values.PCollection;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+public class PythonMap<InputT, OutputT>
+ extends PTransform<PCollection<? extends InputT>, PCollection<OutputT>> {
+
+ private PythonCallableSource pythonFunction;
+ private @Nullable String expansionService;
+ private Coder<?> outputCoder;
+ private static final String PYTHON_MAP_FN_TRANSFORM = "apache_beam.Map";
+ private static final String PYTHON_FLATMAP_FN_TRANSFORM = "apache_beam.FlatMap";
+ private String pythonTransform;
+
+ private PythonMap(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder, String pythonTransform) {
+ this.pythonFunction = pythonFunction;
+ this.outputCoder = outputCoder;
+ this.pythonTransform = pythonTransform;
+ }
+
+ public static <InputT, OutputT> PythonMap<InputT, OutputT> viaMapFn(
+ PythonCallableSource pythonFunction, Coder<?> outputCoder) {
Review Comment:
I think we might extend `PythonCallableSource` with the context that `exec`ed before calling a callable like
```
PythonCallableSource.of("lambda x: os.environ['PREFIX']+x").withContext("import os")
```
We don't need to update the method signature when we pass `PythonCallableSource` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1136448886
Run XVR_Direct PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #17696: [BEAM-14483] Adds Java cross-language transforms for invoking Python Map and FlatMap
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #17696:
URL: https://github.com/apache/beam/pull/17696#issuecomment-1136553821
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org