You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by jfiala <gi...@git.apache.org> on 2016/07/09 17:16:42 UTC
[GitHub] cxf pull request #146: Add basic bean-validation (JSR-303) support + Swagger...
GitHub user jfiala opened a pull request:
https://github.com/apache/cxf/pull/146
Add basic bean-validation (JSR-303) support + Swagger annotation support
Added basic bean-validation and on example for Swagger annotation support to the WadlGenerator for parameters.
# Overview bean-validation support
- [x] @NotNull
- [ ] @Size - add for docs
- [ ] @Min- add for docs
- [ ] @Max - add for docs
- [ ] @Pattern - add for docs
The @NotNull annotation is supported.
The annotations @Size/@Min/@Max/@Pattern are added as documentation for now.
Pls let me know what is the best way to add additional string-restrictions to the schema in doWriteParam?
# Overview Swagger annotation support
- [x] @ApiParam
- [ ] @ApiOperation
- [ ] @ApiResponses / @ApiResponse
- [ ] @ApiModel
Pls let me know if support is desired, then I'll add the others...
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jfiala/cxf master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cxf/pull/146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #146
----
commit 3a8bfa7aa7038478c0f3a552e162ba0e681f04c1
Author: jfiala <jo...@fwd.at>
Date: 2016-07-09T16:47:53Z
add bean-validation support for params in WADLGenerator
commit 6748812e9d4841fe7a1bb64e437ca089f7a12004
Author: jfiala <jo...@fwd.at>
Date: 2016-07-09T17:00:00Z
added addDocumentation helper method
commit b4704dcf71de5b79752752dbc24260e53c8e5f50
Author: jfiala <jo...@fwd.at>
Date: 2016-07-09T17:12:31Z
add Swagger @ApiParam annotation support
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #146: Add basic bean-validation (JSR-303) support + Swagger annota...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala commented on the issue:
https://github.com/apache/cxf/pull/146
moved to PR #194 to change source branch to cxf_beanvalidation_annot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf pull request #146: Add basic bean-validation (JSR-303) support + Swagger...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala closed the pull request at:
https://github.com/apache/cxf/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #146: Add basic bean-validation (JSR-303) support + Swagger annota...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala commented on the issue:
https://github.com/apache/cxf/pull/146
pls advise if I should add the other Swagger-annotations and extract the bean-validation-methods into a separate utility-class?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #146: Add basic bean-validation (JSR-303) support + Swagger annota...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala commented on the issue:
https://github.com/apache/cxf/pull/146
added inline restrictions to schema
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #146: Add basic bean-validation (JSR-303) support + Swagger annota...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala commented on the issue:
https://github.com/apache/cxf/pull/146
According to discussions with Sergey on cxf-users this PR can be turned down in favor of a solution which is valid for wadl2java + WadlGenerator using JAXB.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cxf issue #146: Add basic bean-validation (JSR-303) support + Swagger annota...
Posted by jfiala <gi...@git.apache.org>.
Github user jfiala commented on the issue:
https://github.com/apache/cxf/pull/146
added corresponding part to WadlGenerator: assemble beanvalidation annotations based on simpletype restrictions in SourceGenerator/wadl2java
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---