You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Mitko-Kerezov <gi...@git.apache.org> on 2016/12/14 09:27:07 UTC
[GitHub] cordova-ios pull request #281: Hard link instead of soft linking
GitHub user Mitko-Kerezov opened a pull request:
https://github.com/apache/cordova-ios/pull/281
Hard link instead of soft linking
Softlinking resource files (.wav files [for example](https://github.com/apache/cordova-plugin-dialogs/tree/master/src/ios/CDVNotification.bundle)) leads to some unexpected behavior. Said resource files are stored as symbolic links inside the .ipa and the app cannot be installed on iOS 10.
Instead of creating symbolic link create regular links - it is better than copying the files performance-wise and the solution is more robust.
Part of the fix for[CB-12247: Symlinking resource files leads to inability to install app on iOS 10](https://issues.apache.org/jira/browse/CB-12247)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Icenium/cordova-ios kerezov/hardlink-instead-symlink
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/281.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #281
----
commit 4b7609f8055a03f7b110e4d3a3092d0fb8807421
Author: Dimitar Kerezov <di...@telerik.com>
Date: 2016-12-13T10:50:22Z
Hard link instead of soft linking
Softlinking resource files (.wav files for example) leads to some unexpected behavior. Said resource files are stored as symbolic links inside the .ipa and the app cannot be installed on iOS 10.
Instead of creating symbolic link create regular links - it is better than copying the files performance-wise and the solution is more robust.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request #281: CB-12247: Hard link instead of soft linking
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/281
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #281: CB-12247: Hard link instead of soft linking
Posted by Mitko-Kerezov <gi...@git.apache.org>.
Github user Mitko-Kerezov commented on the issue:
https://github.com/apache/cordova-ios/pull/281
Sure thing @kerrishotts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #281: Hard link instead of soft linking
Posted by kerrishotts <gi...@git.apache.org>.
Github user kerrishotts commented on the issue:
https://github.com/apache/cordova-ios/pull/281
Can you update the title so that it includes the issue number with the following form:
issue#: description
That way the issue tracker will get all the updates here automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios issue #281: Hard link instead of soft linking
Posted by Mitko-Kerezov <gi...@git.apache.org>.
Github user Mitko-Kerezov commented on the issue:
https://github.com/apache/cordova-ios/pull/281
Note: I've tested this with `cordova-android` and it doesn't seem to reproduce - for one reason or another `gradle` seems to follow symlinks when zipping up the `.apk` file, so this fix may be enough to mitigate the whole problem. E.g. there's no need to propagate it to all the other platforms and to plugman as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org