You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/01 17:34:00 UTC
[jira] [Commented] (GEODE-3339) Refactor
ClusterConfigurationServiceEndToEndDUnitTest to use test rules
[ https://issues.apache.org/jira/browse/GEODE-3339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109369#comment-16109369 ]
ASF GitHub Bot commented on GEODE-3339:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/675
GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest
[View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3339)
ClusterConfigurationServiceEndToEndDUnitTest has been refactored to use test rules instead of CliCommandsTestBase, and a version of the test that uses HTTP connection was also added.
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-3339
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #675
----
commit 1f9ad5523bd04706cc96a48db990b4452548a7da
Author: YehEmily <em...@gmail.com>
Date: 2017-08-01T17:30:09Z
GEODE-3339: Refactoring ClusterConfigurationServiceEndToEndDUnitTest
----
> Refactor ClusterConfigurationServiceEndToEndDUnitTest to use test rules
> -----------------------------------------------------------------------
>
> Key: GEODE-3339
> URL: https://issues.apache.org/jira/browse/GEODE-3339
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Reporter: Emily Yeh
> Assignee: Emily Yeh
>
> {{ClusterConfigurationServiceEndToEndDUnitTest}} is using {{CliCommandTestBase}}, which is a deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)