You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2020/06/18 11:47:26 UTC
[GitHub] [incubator-brpc] hcoona opened a new issue #1145: Bazel 编译潜在问题
hcoona opened a new issue #1145:
URL: https://github.com/apache/incubator-brpc/issues/1145
**Describe the bug (描述bug)**
我发现 BUILD 文件中依赖于系统中的 zlib 库（动态链接），但是实际上 protobuf 也依赖于一个 zlib 库（静态链接），这两个 zlib 版本不一致的时候有潜在风险。
**To Reproduce (复现方法)**
**Expected behavior (期望行为)**
**Versions (各种版本)**
OS:
Compiler:
brpc: 0.9.7
protobuf:
**Additional context/screenshots (更多上下文/截图)**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] zyctree commented on issue #1145: Bazel 编译潜在问题（zlib 版本冲突）
Posted by GitBox <gi...@apache.org>.
zyctree commented on issue #1145:
URL: https://github.com/apache/incubator-brpc/issues/1145#issuecomment-646969859
add
```
new_local_repository(
name = "zlib",
build_file = "bazel/zlib.BUILD",
path = "bazel/zlib_empty"
)
```
with content like
```
cc_library(
name = "zlib",
linkopts = [
"-lz",
],
)
```
in workspace
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] hcoona commented on issue #1145: Bazel 编译潜在问题（zlib 版本冲突）
Posted by GitBox <gi...@apache.org>.
hcoona commented on issue #1145:
URL: https://github.com/apache/incubator-brpc/issues/1145#issuecomment-645988854
我发现实际上我们并没有用到 ZLIB，那为什么要有个 `-DHAVE_ZLIB`？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org