You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/05/10 14:22:31 UTC
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/303
DISPATCH-994 - Added null checks on links/connections before enqueing…
… actions or calling action inseting functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-994
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #303
----
commit ea4b67fdc1ccd2dfc52f096308174d3c26fba993
Author: Ganesh Murthy <gm...@...>
Date: 2018-05-10T14:20:50Z
DISPATCH-994 - Added null checks on links/connections before enqueing actions or calling action inseting functions
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/303#discussion_r187373563
--- Diff: src/router_core/connections.c ---
@@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source, qdr_termin
action->args.connection.link = link;
action->args.connection.source = source;
action->args.connection.target = target;
- qdr_action_enqueue(link->core, action);
+ if (link)
--- End diff --
I added the null check in AMQP_link_attach_handler and in qdr_link_second_attach() just to be doubly sure.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Posted by grs <gi...@git.apache.org>.
Github user grs commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/303#discussion_r187367734
--- Diff: src/router_core/connections.c ---
@@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source, qdr_termin
action->args.connection.link = link;
action->args.connection.source = source;
action->args.connection.target = target;
- qdr_action_enqueue(link->core, action);
+ if (link)
--- End diff --
I wonder if the test might be better done in AMQP_link_attach_handler in router_node.c? That is the only place that calls the method, and is the one that retrieves the null context.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/303
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org