You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/31 19:35:52 UTC
[GitHub] [helix] pkuwm commented on a change in pull request #924: WIP: fix
ZkHelixPropertyStore loses Zookeeper notification issue
pkuwm commented on a change in pull request #924: WIP: fix ZkHelixPropertyStore loses Zookeeper notification issue
URL: https://github.com/apache/helix/pull/924#discussion_r401159442
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
##########
@@ -72,6 +72,11 @@
private HelixZkClient _zkClient = null;
+ // test only
+ public HelixZkClient getZkClient() {
Review comment:
This should be introduced. If getZkClient() is really necessary, you can make `_zkClient` as protected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org