You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/12/30 02:17:37 UTC

[commons-beanutils] 02/03: Use Double.valueOf(String)

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 700925ee968c5d6b427d1cd1b5c52d8376a71f19
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Tue Dec 27 09:19:16 2022 -0500

    Use Double.valueOf(String)
---
 src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java  | 2 +-
 .../beanutils2/converters/BigDecimalConverterTestCase.java        | 2 +-
 .../commons/beanutils2/converters/DoubleConverterTestCase.java    | 8 ++++----
 .../locale/converters/DoubleLocaleConverterTestCase.java          | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java b/src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java
index 54baf090..d91ddbc8 100644
--- a/src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/BeanMapTestCase.java
@@ -381,7 +381,7 @@ public class BeanMapTestCase extends AbstractTestMap {
         assertEquals("Integer.TYPE",   new Integer(3),      beanMap.getTypeTransformer(Integer.TYPE).apply("3"));
         assertEquals("Long.TYPE",      new Long(4),         beanMap.getTypeTransformer(Long.TYPE).apply("4"));
         assertEquals("Float.TYPE",     new Float("5"),      beanMap.getTypeTransformer(Float.TYPE).apply("5"));
-        assertEquals("Double.TYPE",    new Double("6"),     beanMap.getTypeTransformer(Double.TYPE).apply("6"));
+        assertEquals("Double.TYPE",    Double.valueOf("6"),     beanMap.getTypeTransformer(Double.TYPE).apply("6"));
     }
 
     /**
diff --git a/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java b/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
index 2e4d7e47..61aeba7e 100644
--- a/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/converters/BigDecimalConverterTestCase.java
@@ -105,7 +105,7 @@ public class BigDecimalConverterTestCase extends NumberConverterTestBase<BigDeci
             new Integer(9),
             new Long(10),
             new Float("11.1"),
-            new Double("12.2"),
+            Double.valueOf("12.2"),
             new BigDecimal("3200.11"),
             new ExtendingBigDecimal("3200.11")
         };
diff --git a/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
index 710c74b4..00c08019 100644
--- a/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/converters/DoubleConverterTestCase.java
@@ -54,10 +54,10 @@ public class DoubleConverterTestCase extends NumberConverterTestBase<Double> {
     @Override
     public void setUp() throws Exception {
         converter = makeConverter();
-        numbers[0] = new Double("-12");
-        numbers[1] = new Double("13");
-        numbers[2] = new Double("-22");
-        numbers[3] = new Double("23");
+        numbers[0] = Double.valueOf("-12");
+        numbers[1] = Double.valueOf("13");
+        numbers[2] = Double.valueOf("-22");
+        numbers[3] = Double.valueOf("23");
     }
 
     @Override
diff --git a/src/test/java/org/apache/commons/beanutils2/locale/converters/DoubleLocaleConverterTestCase.java b/src/test/java/org/apache/commons/beanutils2/locale/converters/DoubleLocaleConverterTestCase.java
index 9bd653e8..ecb5d26a 100644
--- a/src/test/java/org/apache/commons/beanutils2/locale/converters/DoubleLocaleConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/locale/converters/DoubleLocaleConverterTestCase.java
@@ -40,8 +40,8 @@ public class DoubleLocaleConverterTestCase extends BaseLocaleConverterTestCase<D
 
         super.setUp();
 
-        defaultValue  = new Double("9.99");
-        expectedValue = new Double(expectedDecimalValue);
+        defaultValue  = Double.valueOf("9.99");
+        expectedValue = Double.valueOf(expectedDecimalValue);
 
     }
 
@@ -77,7 +77,7 @@ public class DoubleLocaleConverterTestCase extends BaseLocaleConverterTestCase<D
         // quite happily turning "1,234.56" into "1.234"
         // I guess this is one of the limitations of DecimalFormat
         // **************************************************************************
-        convertValueNoPattern(converter, "(B)", defaultDecimalValue, new Double("1.234"));
+        convertValueNoPattern(converter, "(B)", defaultDecimalValue, Double.valueOf("1.234"));
 
         // **************************************************************************
         // Convert with non-localized pattern - this causes an exception in parse()