[GitHub] [incubator-kvrocks] PragmaTwice opened a new issue, #569: [QUESTION] Consider introducing target `libkvrocks` and using `file(GLOB ...)` to avoid redundance in CMake

[GitBox <gi...@apache.org>]

PragmaTwice opened a new issue, #569:
URL: https://github.com/apache/incubator-kvrocks/issues/569

   Currently there are three targets in cmakelists: `kvrocks`, `kvrocks2redis` and `unittest`. these three targets have many common properties which are redundant, we can introduce a new target `libkvrocks`, define common properties in this target (e.g. source files in `src/` except `src/main.cc`), header directories to include, compilation options `-Wall ...`, standard versions `cxx_std_11`, etc.), and link this target to `kvrocks`, `kvrocks2redis`, and `unittest`.
   
   We can also use `file(GLOB ...) ` and list operations in CMake to search for specific files in a directory to avoid a handwritten list of source files.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] ShooterIT closed issue #569: Proposal: Consider introducing target `libkvrocks` and using `file(GLOB ...)` to avoid redundance in CMake

[GitBox <gi...@apache.org>]

ShooterIT closed issue #569: Proposal: Consider introducing target `libkvrocks` and using `file(GLOB ...)` to avoid redundance in CMake
URL: https://github.com/apache/incubator-kvrocks/issues/569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org