You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Wang1rrr (via GitHub)" <gi...@apache.org> on 2026/09/21 23:42:37 UTC

[PR] docs: point the pull request template at the rocketmq-studio trunk [rocketmq-dashboard]

Wang1rrr opened a new pull request, #4801:
URL: https://github.com/apache/rocketmq-dashboard/pull/4801

   ### Which Issue(s) This PR Fixes
   
   No issue - the contradiction is visible in the three files named below.
   
   ### Brief Description
   
   `.github/PULL_REQUEST_TEMPLATE.md` opens with:
   
   ```
   <!-- Make sure the base branch is `master`: that is the RocketMQ Studio trunk. -->
   ```
   
   `master` is no longer the trunk, and the rest of the repository says so:
   
   - `CONTRIBUTING.md:8` - "All pull requests must target `rocketmq-studio`."
   - `CONTRIBUTING.md:13` - branch table: "`rocketmq-studio` | RocketMQ Studio trunk - base your branches and pull requests on it"
   - `CONTRIBUTING.md:92` and `:101` - branch from `upstream/rocketmq-studio`, open the pull request against `rocketmq-studio`
   - `README.md:118` - "`rocketmq-studio` is the development trunk"
   - `master` itself - its tip is `docs: update development trunk branch to rocketmq-studio`
   
   So the one file GitHub renders in front of a contributor at the moment they open a pull request is the one file that still names the wrong base, and it is the file whose checklist they are being asked to read. A pull request opened against `master` will not pick up any of the trunk's recent merges.
   
   The change corrects the branch name only; the rest of the sentence is accurate as it stands.
   
   ### How Did You Test This Change?
   
   Documentation only, no code path touched. Verified the contradiction and that this is the only stale reference:
   
   ```
   rg -n "rocketmq-studio|base branch|trunk" CONTRIBUTING.md .github/PULL_REQUEST_TEMPLATE.md README.md
   .github/PULL_REQUEST_TEMPLATE.md:1:<!-- Make sure the base branch is `master`: ... -->
   CONTRIBUTING.md:8:**`rocketmq-studio`** branch, which is also the repository default branch. All pull requests must
   CONTRIBUTING.md:9:target `rocketmq-studio`.
   CONTRIBUTING.md:13:| `rocketmq-studio` | RocketMQ Studio trunk - base your branches and pull requests on it |
   CONTRIBUTING.md:92:4. **Fork, branch, commit.** Create your branch from `rocketmq-studio`:
   CONTRIBUTING.md:101:5. **Open a pull request against `rocketmq-studio`** ...
   README.md:118:- **Branches** - `rocketmq-studio` is the development trunk ...
   ```
   
   `rg -n master .github/PULL_REQUEST_TEMPLATE.md` returns nothing after the change, so no other reference to the old base survives in the template.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`)
   - [ ] Tests added or updated for non-trivial changes, test methods named `...Test` - N/A, documentation only
   - [ ] New UI text has both Chinese and English entries under `web/src/i18n/` - N/A, not user-facing app text
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit checks) - N/A, no source change
   - [ ] New source files carry the ASF license header - N/A, no new files
   - [x] Documentation touched where behaviour changed - this is the documentation change
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: point the pull request template at the rocketmq-studio trunk [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #4801: docs: point the pull request template at the rocketmq-studio trunk
URL: https://github.com/apache/rocketmq-dashboard/pull/4801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: point the pull request template at the rocketmq-studio trunk [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #4801:
URL: https://github.com/apache/rocketmq-dashboard/pull/4801#issuecomment-5845587253

   Thanks for catching this — the correction itself is right: `.github/PULL_REQUEST_TEMPLATE.md:1` still names `master` as the base, while `CONTRIBUTING.md:8-9` says every pull request must target `rocketmq-studio` (same at `:13`, `:92`, `:101`, and `README.md:152`).
   
   We are closing it because the description's check ("this is the only stale reference") does not hold, and fixing the template alone leaves the issue forms pointing contributors at the wrong base:
   
   - `.github/ISSUE_TEMPLATE/doc.yml:64` — "Base the branch on `master`"
   - `.github/ISSUE_TEMPLATE/enhancement_request.yml:85` — "Pull requests target the `master` branch"
   - `.github/ISSUE_TEMPLATE/feature_request.yml:75` — "the pull request must target `master`"
   - `.github/ISSUE_TEMPLATE/bug_report.yml:135` — "pull requests target the `master` branch"
   - `.github/ISSUE_TEMPLATE/bug_report.yml:36` and `:45` — reproduce on / report against `master`
   
   Please resubmit this as one change that sweeps all of `.github/`, and correct two claims in the description: the `README.md` citation is line 152, not 118; and `master`'s tip is now `chore(studio): 3.0.0 release readiness (#5007)`, 52 commits behind the trunk at the time of writing, so a pull request based on `master` silently misses everything merged since — that is the argument that actually matters here. One coherent pass over the templates is also what `CONTRIBUTING.md:112-113` asks for. We will merge that version.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org