You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2017/08/18 15:06:44 UTC
[17/30] hbase-site git commit: Published site at .
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactionPipeline.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactionPipeline.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactionPipeline.html
index a736734..0522a39 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactionPipeline.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/CompactionPipeline.html
@@ -51,10 +51,10 @@
<span class="sourceLineNo">043</span> * suffix of the pipeline.<a name="line.43"></a>
<span class="sourceLineNo">044</span> *<a name="line.44"></a>
<span class="sourceLineNo">045</span> * The synchronization model is copy-on-write. Methods which change the structure of the<a name="line.45"></a>
-<span class="sourceLineNo">046</span> * pipeline (pushHead() and swap()) apply their changes in the context of a lock. They also make<a name="line.46"></a>
-<span class="sourceLineNo">047</span> * a read-only copy of the pipeline's list. Read methods read from a read-only copy. If a read<a name="line.47"></a>
-<span class="sourceLineNo">048</span> * method accesses the read-only copy more than once it makes a local copy of it<a name="line.48"></a>
-<span class="sourceLineNo">049</span> * to ensure it accesses the same copy.<a name="line.49"></a>
+<span class="sourceLineNo">046</span> * pipeline (pushHead(), flattenOneSegment() and swap()) apply their changes in the context of a<a name="line.46"></a>
+<span class="sourceLineNo">047</span> * lock. They also make a read-only copy of the pipeline's list. Read methods read from a<a name="line.47"></a>
+<span class="sourceLineNo">048</span> * read-only copy. If a read method accesses the read-only copy more than once it makes a local<a name="line.48"></a>
+<span class="sourceLineNo">049</span> * copy of it to ensure it accesses the same copy.<a name="line.49"></a>
<span class="sourceLineNo">050</span> *<a name="line.50"></a>
<span class="sourceLineNo">051</span> * The methods getVersionedList(), getVersionedTail(), and flattenOneSegment() are also<a name="line.51"></a>
<span class="sourceLineNo">052</span> * protected by a lock since they need to have a consistent (atomic) view of the pipeline list<a name="line.52"></a>
@@ -269,68 +269,75 @@
<span class="sourceLineNo">261</span><a name="line.261"></a>
<span class="sourceLineNo">262</span> private void swapSuffix(List<? extends Segment> suffix, ImmutableSegment segment,<a name="line.262"></a>
<span class="sourceLineNo">263</span> boolean closeSegmentsInSuffix) {<a name="line.263"></a>
-<span class="sourceLineNo">264</span> // During index merge we won't be closing the segments undergoing the merge. Segment#close()<a name="line.264"></a>
-<span class="sourceLineNo">265</span> // will release the MSLAB chunks to pool. But in case of index merge there wont be any data copy<a name="line.265"></a>
-<span class="sourceLineNo">266</span> // from old MSLABs. So the new cells in new segment also refers to same chunks. In case of data<a name="line.266"></a>
-<span class="sourceLineNo">267</span> // compaction, we would have copied the cells data from old MSLAB chunks into a new chunk<a name="line.267"></a>
-<span class="sourceLineNo">268</span> // created for the result segment. So we can release the chunks associated with the compacted<a name="line.268"></a>
-<span class="sourceLineNo">269</span> // segments.<a name="line.269"></a>
-<span class="sourceLineNo">270</span> if (closeSegmentsInSuffix) {<a name="line.270"></a>
-<span class="sourceLineNo">271</span> for (Segment itemInSuffix : suffix) {<a name="line.271"></a>
-<span class="sourceLineNo">272</span> itemInSuffix.close();<a name="line.272"></a>
-<span class="sourceLineNo">273</span> }<a name="line.273"></a>
-<span class="sourceLineNo">274</span> }<a name="line.274"></a>
-<span class="sourceLineNo">275</span> pipeline.removeAll(suffix);<a name="line.275"></a>
-<span class="sourceLineNo">276</span> if(segment != null) pipeline.addLast(segment);<a name="line.276"></a>
+<span class="sourceLineNo">264</span> pipeline.removeAll(suffix);<a name="line.264"></a>
+<span class="sourceLineNo">265</span> if(segment != null) pipeline.addLast(segment);<a name="line.265"></a>
+<span class="sourceLineNo">266</span> // During index merge we won't be closing the segments undergoing the merge. Segment#close()<a name="line.266"></a>
+<span class="sourceLineNo">267</span> // will release the MSLAB chunks to pool. But in case of index merge there wont be any data copy<a name="line.267"></a>
+<span class="sourceLineNo">268</span> // from old MSLABs. So the new cells in new segment also refers to same chunks. In case of data<a name="line.268"></a>
+<span class="sourceLineNo">269</span> // compaction, we would have copied the cells data from old MSLAB chunks into a new chunk<a name="line.269"></a>
+<span class="sourceLineNo">270</span> // created for the result segment. So we can release the chunks associated with the compacted<a name="line.270"></a>
+<span class="sourceLineNo">271</span> // segments.<a name="line.271"></a>
+<span class="sourceLineNo">272</span> if (closeSegmentsInSuffix) {<a name="line.272"></a>
+<span class="sourceLineNo">273</span> for (Segment itemInSuffix : suffix) {<a name="line.273"></a>
+<span class="sourceLineNo">274</span> itemInSuffix.close();<a name="line.274"></a>
+<span class="sourceLineNo">275</span> }<a name="line.275"></a>
+<span class="sourceLineNo">276</span> }<a name="line.276"></a>
<span class="sourceLineNo">277</span> }<a name="line.277"></a>
<span class="sourceLineNo">278</span><a name="line.278"></a>
<span class="sourceLineNo">279</span> // replacing one segment in the pipeline with a new one exactly at the same index<a name="line.279"></a>
<span class="sourceLineNo">280</span> // need to be called only within synchronized block<a name="line.280"></a>
-<span class="sourceLineNo">281</span> private void replaceAtIndex(int idx, ImmutableSegment newSegment) {<a name="line.281"></a>
-<span class="sourceLineNo">282</span> pipeline.set(idx, newSegment);<a name="line.282"></a>
-<span class="sourceLineNo">283</span> readOnlyCopy = new LinkedList<>(pipeline);<a name="line.283"></a>
-<span class="sourceLineNo">284</span> }<a name="line.284"></a>
-<span class="sourceLineNo">285</span><a name="line.285"></a>
-<span class="sourceLineNo">286</span> public Segment getTail() {<a name="line.286"></a>
-<span class="sourceLineNo">287</span> List<? extends Segment> localCopy = getSegments();<a name="line.287"></a>
-<span class="sourceLineNo">288</span> if(localCopy.isEmpty()) {<a name="line.288"></a>
-<span class="sourceLineNo">289</span> return null;<a name="line.289"></a>
-<span class="sourceLineNo">290</span> }<a name="line.290"></a>
-<span class="sourceLineNo">291</span> return localCopy.get(localCopy.size() - 1);<a name="line.291"></a>
-<span class="sourceLineNo">292</span> }<a name="line.292"></a>
-<span class="sourceLineNo">293</span><a name="line.293"></a>
-<span class="sourceLineNo">294</span> private boolean addFirst(ImmutableSegment segment) {<a name="line.294"></a>
-<span class="sourceLineNo">295</span> pipeline.addFirst(segment);<a name="line.295"></a>
-<span class="sourceLineNo">296</span> return true;<a name="line.296"></a>
-<span class="sourceLineNo">297</span> }<a name="line.297"></a>
-<span class="sourceLineNo">298</span><a name="line.298"></a>
-<span class="sourceLineNo">299</span> // debug method<a name="line.299"></a>
-<span class="sourceLineNo">300</span> private boolean validateSuffixList(LinkedList<ImmutableSegment> suffix) {<a name="line.300"></a>
-<span class="sourceLineNo">301</span> if(suffix.isEmpty()) {<a name="line.301"></a>
-<span class="sourceLineNo">302</span> // empty suffix is always valid<a name="line.302"></a>
-<span class="sourceLineNo">303</span> return true;<a name="line.303"></a>
-<span class="sourceLineNo">304</span> }<a name="line.304"></a>
-<span class="sourceLineNo">305</span> Iterator<ImmutableSegment> pipelineBackwardIterator = pipeline.descendingIterator();<a name="line.305"></a>
-<span class="sourceLineNo">306</span> Iterator<ImmutableSegment> suffixBackwardIterator = suffix.descendingIterator();<a name="line.306"></a>
-<span class="sourceLineNo">307</span> ImmutableSegment suffixCurrent;<a name="line.307"></a>
-<span class="sourceLineNo">308</span> ImmutableSegment pipelineCurrent;<a name="line.308"></a>
-<span class="sourceLineNo">309</span> for( ; suffixBackwardIterator.hasNext(); ) {<a name="line.309"></a>
-<span class="sourceLineNo">310</span> if(!pipelineBackwardIterator.hasNext()) {<a name="line.310"></a>
-<span class="sourceLineNo">311</span> // a suffix longer than pipeline is invalid<a name="line.311"></a>
-<span class="sourceLineNo">312</span> return false;<a name="line.312"></a>
-<span class="sourceLineNo">313</span> }<a name="line.313"></a>
-<span class="sourceLineNo">314</span> suffixCurrent = suffixBackwardIterator.next();<a name="line.314"></a>
-<span class="sourceLineNo">315</span> pipelineCurrent = pipelineBackwardIterator.next();<a name="line.315"></a>
-<span class="sourceLineNo">316</span> if(suffixCurrent != pipelineCurrent) {<a name="line.316"></a>
-<span class="sourceLineNo">317</span> // non-matching suffix<a name="line.317"></a>
-<span class="sourceLineNo">318</span> return false;<a name="line.318"></a>
-<span class="sourceLineNo">319</span> }<a name="line.319"></a>
-<span class="sourceLineNo">320</span> }<a name="line.320"></a>
-<span class="sourceLineNo">321</span> // suffix matches pipeline suffix<a name="line.321"></a>
-<span class="sourceLineNo">322</span> return true;<a name="line.322"></a>
-<span class="sourceLineNo">323</span> }<a name="line.323"></a>
-<span class="sourceLineNo">324</span><a name="line.324"></a>
-<span class="sourceLineNo">325</span>}<a name="line.325"></a>
+<span class="sourceLineNo">281</span> @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="VO_VOLATILE_INCREMENT",<a name="line.281"></a>
+<span class="sourceLineNo">282</span> justification="replaceAtIndex is invoked under a synchronize block so safe")<a name="line.282"></a>
+<span class="sourceLineNo">283</span> private void replaceAtIndex(int idx, ImmutableSegment newSegment) {<a name="line.283"></a>
+<span class="sourceLineNo">284</span> pipeline.set(idx, newSegment);<a name="line.284"></a>
+<span class="sourceLineNo">285</span> readOnlyCopy = new LinkedList<>(pipeline);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> // the version increment is indeed needed, because the swap uses removeAll() method of the<a name="line.286"></a>
+<span class="sourceLineNo">287</span> // linked-list that compares the objects to find what to remove.<a name="line.287"></a>
+<span class="sourceLineNo">288</span> // The flattening changes the segment object completely (creation pattern) and so<a name="line.288"></a>
+<span class="sourceLineNo">289</span> // swap will not proceed correctly after concurrent flattening.<a name="line.289"></a>
+<span class="sourceLineNo">290</span> version++;<a name="line.290"></a>
+<span class="sourceLineNo">291</span> }<a name="line.291"></a>
+<span class="sourceLineNo">292</span><a name="line.292"></a>
+<span class="sourceLineNo">293</span> public Segment getTail() {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> List<? extends Segment> localCopy = getSegments();<a name="line.294"></a>
+<span class="sourceLineNo">295</span> if(localCopy.isEmpty()) {<a name="line.295"></a>
+<span class="sourceLineNo">296</span> return null;<a name="line.296"></a>
+<span class="sourceLineNo">297</span> }<a name="line.297"></a>
+<span class="sourceLineNo">298</span> return localCopy.get(localCopy.size() - 1);<a name="line.298"></a>
+<span class="sourceLineNo">299</span> }<a name="line.299"></a>
+<span class="sourceLineNo">300</span><a name="line.300"></a>
+<span class="sourceLineNo">301</span> private boolean addFirst(ImmutableSegment segment) {<a name="line.301"></a>
+<span class="sourceLineNo">302</span> pipeline.addFirst(segment);<a name="line.302"></a>
+<span class="sourceLineNo">303</span> return true;<a name="line.303"></a>
+<span class="sourceLineNo">304</span> }<a name="line.304"></a>
+<span class="sourceLineNo">305</span><a name="line.305"></a>
+<span class="sourceLineNo">306</span> // debug method<a name="line.306"></a>
+<span class="sourceLineNo">307</span> private boolean validateSuffixList(LinkedList<ImmutableSegment> suffix) {<a name="line.307"></a>
+<span class="sourceLineNo">308</span> if(suffix.isEmpty()) {<a name="line.308"></a>
+<span class="sourceLineNo">309</span> // empty suffix is always valid<a name="line.309"></a>
+<span class="sourceLineNo">310</span> return true;<a name="line.310"></a>
+<span class="sourceLineNo">311</span> }<a name="line.311"></a>
+<span class="sourceLineNo">312</span> Iterator<ImmutableSegment> pipelineBackwardIterator = pipeline.descendingIterator();<a name="line.312"></a>
+<span class="sourceLineNo">313</span> Iterator<ImmutableSegment> suffixBackwardIterator = suffix.descendingIterator();<a name="line.313"></a>
+<span class="sourceLineNo">314</span> ImmutableSegment suffixCurrent;<a name="line.314"></a>
+<span class="sourceLineNo">315</span> ImmutableSegment pipelineCurrent;<a name="line.315"></a>
+<span class="sourceLineNo">316</span> for( ; suffixBackwardIterator.hasNext(); ) {<a name="line.316"></a>
+<span class="sourceLineNo">317</span> if(!pipelineBackwardIterator.hasNext()) {<a name="line.317"></a>
+<span class="sourceLineNo">318</span> // a suffix longer than pipeline is invalid<a name="line.318"></a>
+<span class="sourceLineNo">319</span> return false;<a name="line.319"></a>
+<span class="sourceLineNo">320</span> }<a name="line.320"></a>
+<span class="sourceLineNo">321</span> suffixCurrent = suffixBackwardIterator.next();<a name="line.321"></a>
+<span class="sourceLineNo">322</span> pipelineCurrent = pipelineBackwardIterator.next();<a name="line.322"></a>
+<span class="sourceLineNo">323</span> if(suffixCurrent != pipelineCurrent) {<a name="line.323"></a>
+<span class="sourceLineNo">324</span> // non-matching suffix<a name="line.324"></a>
+<span class="sourceLineNo">325</span> return false;<a name="line.325"></a>
+<span class="sourceLineNo">326</span> }<a name="line.326"></a>
+<span class="sourceLineNo">327</span> }<a name="line.327"></a>
+<span class="sourceLineNo">328</span> // suffix matches pipeline suffix<a name="line.328"></a>
+<span class="sourceLineNo">329</span> return true;<a name="line.329"></a>
+<span class="sourceLineNo">330</span> }<a name="line.330"></a>
+<span class="sourceLineNo">331</span><a name="line.331"></a>
+<span class="sourceLineNo">332</span>}<a name="line.332"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.CompactionChecker.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.CompactionChecker.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.CompactionChecker.html
index 61c9b54..a7697c0 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.CompactionChecker.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.CompactionChecker.html
@@ -650,7 +650,7 @@
<span class="sourceLineNo">642</span> if (!conf.getBoolean("hbase.testing.nocluster", false)) {<a name="line.642"></a>
<span class="sourceLineNo">643</span> // Open connection to zookeeper and set primary watcher<a name="line.643"></a>
<span class="sourceLineNo">644</span> zooKeeper = new ZooKeeperWatcher(conf, getProcessName() + ":" +<a name="line.644"></a>
-<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode());<a name="line.645"></a>
+<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode(), true);<a name="line.645"></a>
<span class="sourceLineNo">646</span><a name="line.646"></a>
<span class="sourceLineNo">647</span> this.csm = (BaseCoordinatedStateManager) csm;<a name="line.647"></a>
<span class="sourceLineNo">648</span> this.csm.initialize(this);<a name="line.648"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionInfo.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionInfo.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionInfo.html
index 61c9b54..a7697c0 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionInfo.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionInfo.html
@@ -650,7 +650,7 @@
<span class="sourceLineNo">642</span> if (!conf.getBoolean("hbase.testing.nocluster", false)) {<a name="line.642"></a>
<span class="sourceLineNo">643</span> // Open connection to zookeeper and set primary watcher<a name="line.643"></a>
<span class="sourceLineNo">644</span> zooKeeper = new ZooKeeperWatcher(conf, getProcessName() + ":" +<a name="line.644"></a>
-<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode());<a name="line.645"></a>
+<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode(), true);<a name="line.645"></a>
<span class="sourceLineNo">646</span><a name="line.646"></a>
<span class="sourceLineNo">647</span> this.csm = (BaseCoordinatedStateManager) csm;<a name="line.647"></a>
<span class="sourceLineNo">648</span> this.csm.initialize(this);<a name="line.648"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionsCleaner.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionsCleaner.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionsCleaner.html
index 61c9b54..a7697c0 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionsCleaner.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.MovedRegionsCleaner.html
@@ -650,7 +650,7 @@
<span class="sourceLineNo">642</span> if (!conf.getBoolean("hbase.testing.nocluster", false)) {<a name="line.642"></a>
<span class="sourceLineNo">643</span> // Open connection to zookeeper and set primary watcher<a name="line.643"></a>
<span class="sourceLineNo">644</span> zooKeeper = new ZooKeeperWatcher(conf, getProcessName() + ":" +<a name="line.644"></a>
-<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode());<a name="line.645"></a>
+<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode(), true);<a name="line.645"></a>
<span class="sourceLineNo">646</span><a name="line.646"></a>
<span class="sourceLineNo">647</span> this.csm = (BaseCoordinatedStateManager) csm;<a name="line.647"></a>
<span class="sourceLineNo">648</span> this.csm.initialize(this);<a name="line.648"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.PeriodicMemstoreFlusher.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.PeriodicMemstoreFlusher.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.PeriodicMemstoreFlusher.html
index 61c9b54..a7697c0 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.PeriodicMemstoreFlusher.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.PeriodicMemstoreFlusher.html
@@ -650,7 +650,7 @@
<span class="sourceLineNo">642</span> if (!conf.getBoolean("hbase.testing.nocluster", false)) {<a name="line.642"></a>
<span class="sourceLineNo">643</span> // Open connection to zookeeper and set primary watcher<a name="line.643"></a>
<span class="sourceLineNo">644</span> zooKeeper = new ZooKeeperWatcher(conf, getProcessName() + ":" +<a name="line.644"></a>
-<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode());<a name="line.645"></a>
+<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode(), true);<a name="line.645"></a>
<span class="sourceLineNo">646</span><a name="line.646"></a>
<span class="sourceLineNo">647</span> this.csm = (BaseCoordinatedStateManager) csm;<a name="line.647"></a>
<span class="sourceLineNo">648</span> this.csm.initialize(this);<a name="line.648"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.html
index 61c9b54..a7697c0 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/HRegionServer.html
@@ -650,7 +650,7 @@
<span class="sourceLineNo">642</span> if (!conf.getBoolean("hbase.testing.nocluster", false)) {<a name="line.642"></a>
<span class="sourceLineNo">643</span> // Open connection to zookeeper and set primary watcher<a name="line.643"></a>
<span class="sourceLineNo">644</span> zooKeeper = new ZooKeeperWatcher(conf, getProcessName() + ":" +<a name="line.644"></a>
-<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode());<a name="line.645"></a>
+<span class="sourceLineNo">645</span> rpcServices.isa.getPort(), this, canCreateBaseZNode(), true);<a name="line.645"></a>
<span class="sourceLineNo">646</span><a name="line.646"></a>
<span class="sourceLineNo">647</span> this.csm = (BaseCoordinatedStateManager) csm;<a name="line.647"></a>
<span class="sourceLineNo">648</span> this.csm.initialize(this);<a name="line.648"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/cef8af03/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
index f19fbda..a1f9481 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/regionserver/MemStoreLABImpl.html
@@ -86,209 +86,226 @@
<span class="sourceLineNo">078</span> private final int chunkSize;<a name="line.78"></a>
<span class="sourceLineNo">079</span> private final int maxAlloc;<a name="line.79"></a>
<span class="sourceLineNo">080</span> private final ChunkCreator chunkCreator;<a name="line.80"></a>
-<span class="sourceLineNo">081</span><a name="line.81"></a>
-<span class="sourceLineNo">082</span> // This flag is for closing this instance, its set when clearing snapshot of<a name="line.82"></a>
-<span class="sourceLineNo">083</span> // memstore<a name="line.83"></a>
-<span class="sourceLineNo">084</span> private volatile boolean closed = false;<a name="line.84"></a>
-<span class="sourceLineNo">085</span> // This flag is for reclaiming chunks. Its set when putting chunks back to<a name="line.85"></a>
-<span class="sourceLineNo">086</span> // pool<a name="line.86"></a>
-<span class="sourceLineNo">087</span> private AtomicBoolean reclaimed = new AtomicBoolean(false);<a name="line.87"></a>
-<span class="sourceLineNo">088</span> // Current count of open scanners which reading data from this MemStoreLAB<a name="line.88"></a>
-<span class="sourceLineNo">089</span> private final AtomicInteger openScannerCount = new AtomicInteger();<a name="line.89"></a>
-<span class="sourceLineNo">090</span><a name="line.90"></a>
-<span class="sourceLineNo">091</span> // Used in testing<a name="line.91"></a>
-<span class="sourceLineNo">092</span> public MemStoreLABImpl() {<a name="line.92"></a>
-<span class="sourceLineNo">093</span> this(new Configuration());<a name="line.93"></a>
-<span class="sourceLineNo">094</span> }<a name="line.94"></a>
-<span class="sourceLineNo">095</span><a name="line.95"></a>
-<span class="sourceLineNo">096</span> public MemStoreLABImpl(Configuration conf) {<a name="line.96"></a>
-<span class="sourceLineNo">097</span> chunkSize = conf.getInt(CHUNK_SIZE_KEY, CHUNK_SIZE_DEFAULT);<a name="line.97"></a>
-<span class="sourceLineNo">098</span> maxAlloc = conf.getInt(MAX_ALLOC_KEY, MAX_ALLOC_DEFAULT);<a name="line.98"></a>
-<span class="sourceLineNo">099</span> this.chunkCreator = ChunkCreator.getInstance();<a name="line.99"></a>
-<span class="sourceLineNo">100</span> // if we don't exclude allocations >CHUNK_SIZE, we'd infiniteloop on one!<a name="line.100"></a>
-<span class="sourceLineNo">101</span> Preconditions.checkArgument(maxAlloc <= chunkSize,<a name="line.101"></a>
-<span class="sourceLineNo">102</span> MAX_ALLOC_KEY + " must be less than " + CHUNK_SIZE_KEY);<a name="line.102"></a>
-<span class="sourceLineNo">103</span> }<a name="line.103"></a>
-<span class="sourceLineNo">104</span><a name="line.104"></a>
-<span class="sourceLineNo">105</span> @Override<a name="line.105"></a>
-<span class="sourceLineNo">106</span> public Cell copyCellInto(Cell cell) {<a name="line.106"></a>
-<span class="sourceLineNo">107</span> int size = KeyValueUtil.length(cell);<a name="line.107"></a>
-<span class="sourceLineNo">108</span> Preconditions.checkArgument(size >= 0, "negative size");<a name="line.108"></a>
-<span class="sourceLineNo">109</span> // Callers should satisfy large allocations directly from JVM since they<a name="line.109"></a>
-<span class="sourceLineNo">110</span> // don't cause fragmentation as badly.<a name="line.110"></a>
-<span class="sourceLineNo">111</span> if (size > maxAlloc) {<a name="line.111"></a>
-<span class="sourceLineNo">112</span> return null;<a name="line.112"></a>
-<span class="sourceLineNo">113</span> }<a name="line.113"></a>
-<span class="sourceLineNo">114</span> Chunk c = null;<a name="line.114"></a>
-<span class="sourceLineNo">115</span> int allocOffset = 0;<a name="line.115"></a>
-<span class="sourceLineNo">116</span> while (true) {<a name="line.116"></a>
-<span class="sourceLineNo">117</span> // Try to get the chunk<a name="line.117"></a>
-<span class="sourceLineNo">118</span> c = getOrMakeChunk();<a name="line.118"></a>
-<span class="sourceLineNo">119</span> // we may get null because the some other thread succeeded in getting the lock<a name="line.119"></a>
-<span class="sourceLineNo">120</span> // and so the current thread has to try again to make its chunk or grab the chunk<a name="line.120"></a>
-<span class="sourceLineNo">121</span> // that the other thread created<a name="line.121"></a>
-<span class="sourceLineNo">122</span> // Try to allocate from this chunk<a name="line.122"></a>
-<span class="sourceLineNo">123</span> if (c != null) {<a name="line.123"></a>
-<span class="sourceLineNo">124</span> allocOffset = c.alloc(size);<a name="line.124"></a>
-<span class="sourceLineNo">125</span> if (allocOffset != -1) {<a name="line.125"></a>
-<span class="sourceLineNo">126</span> // We succeeded - this is the common case - small alloc<a name="line.126"></a>
-<span class="sourceLineNo">127</span> // from a big buffer<a name="line.127"></a>
-<span class="sourceLineNo">128</span> break;<a name="line.128"></a>
-<span class="sourceLineNo">129</span> }<a name="line.129"></a>
-<span class="sourceLineNo">130</span> // not enough space!<a name="line.130"></a>
-<span class="sourceLineNo">131</span> // try to retire this chunk<a name="line.131"></a>
-<span class="sourceLineNo">132</span> tryRetireChunk(c);<a name="line.132"></a>
-<span class="sourceLineNo">133</span> }<a name="line.133"></a>
-<span class="sourceLineNo">134</span> }<a name="line.134"></a>
-<span class="sourceLineNo">135</span> return copyToChunkCell(cell, c.getData(), allocOffset, size);<a name="line.135"></a>
-<span class="sourceLineNo">136</span> }<a name="line.136"></a>
-<span class="sourceLineNo">137</span><a name="line.137"></a>
-<span class="sourceLineNo">138</span> /**<a name="line.138"></a>
-<span class="sourceLineNo">139</span> * Clone the passed cell by copying its data into the passed buf and create a cell with a chunkid<a name="line.139"></a>
-<span class="sourceLineNo">140</span> * out of it<a name="line.140"></a>
-<span class="sourceLineNo">141</span> */<a name="line.141"></a>
-<span class="sourceLineNo">142</span> private Cell copyToChunkCell(Cell cell, ByteBuffer buf, int offset, int len) {<a name="line.142"></a>
-<span class="sourceLineNo">143</span> int tagsLen = cell.getTagsLength();<a name="line.143"></a>
-<span class="sourceLineNo">144</span> if (cell instanceof ExtendedCell) {<a name="line.144"></a>
-<span class="sourceLineNo">145</span> ((ExtendedCell) cell).write(buf, offset);<a name="line.145"></a>
-<span class="sourceLineNo">146</span> } else {<a name="line.146"></a>
-<span class="sourceLineNo">147</span> // Normally all Cell impls within Server will be of type ExtendedCell. Just considering the<a name="line.147"></a>
-<span class="sourceLineNo">148</span> // other case also. The data fragments within Cell is copied into buf as in KeyValue<a name="line.148"></a>
-<span class="sourceLineNo">149</span> // serialization format only.<a name="line.149"></a>
-<span class="sourceLineNo">150</span> KeyValueUtil.appendTo(cell, buf, offset, true);<a name="line.150"></a>
-<span class="sourceLineNo">151</span> }<a name="line.151"></a>
-<span class="sourceLineNo">152</span> // TODO : write the seqid here. For writing seqId we should create a new cell type so<a name="line.152"></a>
-<span class="sourceLineNo">153</span> // that seqId is not used as the state<a name="line.153"></a>
-<span class="sourceLineNo">154</span> if (tagsLen == 0) {<a name="line.154"></a>
-<span class="sourceLineNo">155</span> // When tagsLen is 0, make a NoTagsByteBufferKeyValue version. This is an optimized class<a name="line.155"></a>
-<span class="sourceLineNo">156</span> // which directly return tagsLen as 0. So we avoid parsing many length components in<a name="line.156"></a>
-<span class="sourceLineNo">157</span> // reading the tagLength stored in the backing buffer. The Memstore addition of every Cell<a name="line.157"></a>
-<span class="sourceLineNo">158</span> // call getTagsLength().<a name="line.158"></a>
-<span class="sourceLineNo">159</span> return new NoTagByteBufferChunkCell(buf, offset, len, cell.getSequenceId());<a name="line.159"></a>
-<span class="sourceLineNo">160</span> } else {<a name="line.160"></a>
-<span class="sourceLineNo">161</span> return new ByteBufferChunkCell(buf, offset, len, cell.getSequenceId());<a name="line.161"></a>
-<span class="sourceLineNo">162</span> }<a name="line.162"></a>
-<span class="sourceLineNo">163</span> }<a name="line.163"></a>
-<span class="sourceLineNo">164</span><a name="line.164"></a>
-<span class="sourceLineNo">165</span> /**<a name="line.165"></a>
-<span class="sourceLineNo">166</span> * Close this instance since it won't be used any more, try to put the chunks<a name="line.166"></a>
-<span class="sourceLineNo">167</span> * back to pool<a name="line.167"></a>
-<span class="sourceLineNo">168</span> */<a name="line.168"></a>
-<span class="sourceLineNo">169</span> @Override<a name="line.169"></a>
-<span class="sourceLineNo">170</span> public void close() {<a name="line.170"></a>
-<span class="sourceLineNo">171</span> this.closed = true;<a name="line.171"></a>
-<span class="sourceLineNo">172</span> // We could put back the chunks to pool for reusing only when there is no<a name="line.172"></a>
-<span class="sourceLineNo">173</span> // opening scanner which will read their data<a name="line.173"></a>
-<span class="sourceLineNo">174</span> int count = openScannerCount.get();<a name="line.174"></a>
-<span class="sourceLineNo">175</span> if(count == 0) {<a name="line.175"></a>
-<span class="sourceLineNo">176</span> recycleChunks();<a name="line.176"></a>
-<span class="sourceLineNo">177</span> }<a name="line.177"></a>
-<span class="sourceLineNo">178</span> }<a name="line.178"></a>
-<span class="sourceLineNo">179</span><a name="line.179"></a>
-<span class="sourceLineNo">180</span> /**<a name="line.180"></a>
-<span class="sourceLineNo">181</span> * Called when opening a scanner on the data of this MemStoreLAB<a name="line.181"></a>
-<span class="sourceLineNo">182</span> */<a name="line.182"></a>
-<span class="sourceLineNo">183</span> @Override<a name="line.183"></a>
-<span class="sourceLineNo">184</span> public void incScannerCount() {<a name="line.184"></a>
-<span class="sourceLineNo">185</span> this.openScannerCount.incrementAndGet();<a name="line.185"></a>
-<span class="sourceLineNo">186</span> }<a name="line.186"></a>
-<span class="sourceLineNo">187</span><a name="line.187"></a>
-<span class="sourceLineNo">188</span> /**<a name="line.188"></a>
-<span class="sourceLineNo">189</span> * Called when closing a scanner on the data of this MemStoreLAB<a name="line.189"></a>
-<span class="sourceLineNo">190</span> */<a name="line.190"></a>
-<span class="sourceLineNo">191</span> @Override<a name="line.191"></a>
-<span class="sourceLineNo">192</span> public void decScannerCount() {<a name="line.192"></a>
-<span class="sourceLineNo">193</span> int count = this.openScannerCount.decrementAndGet();<a name="line.193"></a>
-<span class="sourceLineNo">194</span> if (this.closed && count == 0) {<a name="line.194"></a>
-<span class="sourceLineNo">195</span> recycleChunks();<a name="line.195"></a>
-<span class="sourceLineNo">196</span> }<a name="line.196"></a>
-<span class="sourceLineNo">197</span> }<a name="line.197"></a>
-<span class="sourceLineNo">198</span><a name="line.198"></a>
-<span class="sourceLineNo">199</span> private void recycleChunks() {<a name="line.199"></a>
-<span class="sourceLineNo">200</span> if (reclaimed.compareAndSet(false, true)) {<a name="line.200"></a>
-<span class="sourceLineNo">201</span> chunkCreator.putbackChunks(chunks);<a name="line.201"></a>
-<span class="sourceLineNo">202</span> }<a name="line.202"></a>
-<span class="sourceLineNo">203</span> }<a name="line.203"></a>
-<span class="sourceLineNo">204</span><a name="line.204"></a>
-<span class="sourceLineNo">205</span> /**<a name="line.205"></a>
-<span class="sourceLineNo">206</span> * Try to retire the current chunk if it is still<a name="line.206"></a>
-<span class="sourceLineNo">207</span> * <code>c</code>. Postcondition is that curChunk.get()<a name="line.207"></a>
-<span class="sourceLineNo">208</span> * != c<a name="line.208"></a>
-<span class="sourceLineNo">209</span> * @param c the chunk to retire<a name="line.209"></a>
-<span class="sourceLineNo">210</span> * @return true if we won the race to retire the chunk<a name="line.210"></a>
-<span class="sourceLineNo">211</span> */<a name="line.211"></a>
-<span class="sourceLineNo">212</span> private void tryRetireChunk(Chunk c) {<a name="line.212"></a>
-<span class="sourceLineNo">213</span> curChunk.compareAndSet(c, null);<a name="line.213"></a>
-<span class="sourceLineNo">214</span> // If the CAS succeeds, that means that we won the race<a name="line.214"></a>
-<span class="sourceLineNo">215</span> // to retire the chunk. We could use this opportunity to<a name="line.215"></a>
-<span class="sourceLineNo">216</span> // update metrics on external fragmentation.<a name="line.216"></a>
-<span class="sourceLineNo">217</span> //<a name="line.217"></a>
-<span class="sourceLineNo">218</span> // If the CAS fails, that means that someone else already<a name="line.218"></a>
-<span class="sourceLineNo">219</span> // retired the chunk for us.<a name="line.219"></a>
-<span class="sourceLineNo">220</span> }<a name="line.220"></a>
-<span class="sourceLineNo">221</span><a name="line.221"></a>
-<span class="sourceLineNo">222</span> /**<a name="line.222"></a>
-<span class="sourceLineNo">223</span> * Get the current chunk, or, if there is no current chunk,<a name="line.223"></a>
-<span class="sourceLineNo">224</span> * allocate a new one from the JVM.<a name="line.224"></a>
-<span class="sourceLineNo">225</span> */<a name="line.225"></a>
-<span class="sourceLineNo">226</span> private Chunk getOrMakeChunk() {<a name="line.226"></a>
-<span class="sourceLineNo">227</span> // Try to get the chunk<a name="line.227"></a>
-<span class="sourceLineNo">228</span> Chunk c = curChunk.get();<a name="line.228"></a>
-<span class="sourceLineNo">229</span> if (c != null) {<a name="line.229"></a>
-<span class="sourceLineNo">230</span> return c;<a name="line.230"></a>
-<span class="sourceLineNo">231</span> }<a name="line.231"></a>
-<span class="sourceLineNo">232</span> // No current chunk, so we want to allocate one. We race<a name="line.232"></a>
-<span class="sourceLineNo">233</span> // against other allocators to CAS in an uninitialized chunk<a name="line.233"></a>
-<span class="sourceLineNo">234</span> // (which is cheap to allocate)<a name="line.234"></a>
-<span class="sourceLineNo">235</span> if (lock.tryLock()) {<a name="line.235"></a>
-<span class="sourceLineNo">236</span> try {<a name="line.236"></a>
-<span class="sourceLineNo">237</span> // once again check inside the lock<a name="line.237"></a>
-<span class="sourceLineNo">238</span> c = curChunk.get();<a name="line.238"></a>
-<span class="sourceLineNo">239</span> if (c != null) {<a name="line.239"></a>
-<span class="sourceLineNo">240</span> return c;<a name="line.240"></a>
-<span class="sourceLineNo">241</span> }<a name="line.241"></a>
-<span class="sourceLineNo">242</span> c = this.chunkCreator.getChunk();<a name="line.242"></a>
+<span class="sourceLineNo">081</span> private final CompactingMemStore.IndexType idxType; // what index is used for corresponding segment<a name="line.81"></a>
+<span class="sourceLineNo">082</span><a name="line.82"></a>
+<span class="sourceLineNo">083</span> // This flag is for closing this instance, its set when clearing snapshot of<a name="line.83"></a>
+<span class="sourceLineNo">084</span> // memstore<a name="line.84"></a>
+<span class="sourceLineNo">085</span> private volatile boolean closed = false;<a name="line.85"></a>
+<span class="sourceLineNo">086</span> // This flag is for reclaiming chunks. Its set when putting chunks back to<a name="line.86"></a>
+<span class="sourceLineNo">087</span> // pool<a name="line.87"></a>
+<span class="sourceLineNo">088</span> private AtomicBoolean reclaimed = new AtomicBoolean(false);<a name="line.88"></a>
+<span class="sourceLineNo">089</span> // Current count of open scanners which reading data from this MemStoreLAB<a name="line.89"></a>
+<span class="sourceLineNo">090</span> private final AtomicInteger openScannerCount = new AtomicInteger();<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span> // Used in testing<a name="line.92"></a>
+<span class="sourceLineNo">093</span> public MemStoreLABImpl() {<a name="line.93"></a>
+<span class="sourceLineNo">094</span> this(new Configuration());<a name="line.94"></a>
+<span class="sourceLineNo">095</span> }<a name="line.95"></a>
+<span class="sourceLineNo">096</span><a name="line.96"></a>
+<span class="sourceLineNo">097</span> public MemStoreLABImpl(Configuration conf) {<a name="line.97"></a>
+<span class="sourceLineNo">098</span> chunkSize = conf.getInt(CHUNK_SIZE_KEY, CHUNK_SIZE_DEFAULT);<a name="line.98"></a>
+<span class="sourceLineNo">099</span> maxAlloc = conf.getInt(MAX_ALLOC_KEY, MAX_ALLOC_DEFAULT);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> this.chunkCreator = ChunkCreator.getInstance();<a name="line.100"></a>
+<span class="sourceLineNo">101</span> // if we don't exclude allocations >CHUNK_SIZE, we'd infiniteloop on one!<a name="line.101"></a>
+<span class="sourceLineNo">102</span> Preconditions.checkArgument(maxAlloc <= chunkSize,<a name="line.102"></a>
+<span class="sourceLineNo">103</span> MAX_ALLOC_KEY + " must be less than " + CHUNK_SIZE_KEY);<a name="line.103"></a>
+<span class="sourceLineNo">104</span> idxType = CompactingMemStore.IndexType.valueOf(conf.get(<a name="line.104"></a>
+<span class="sourceLineNo">105</span> CompactingMemStore.COMPACTING_MEMSTORE_INDEX_KEY,<a name="line.105"></a>
+<span class="sourceLineNo">106</span> CompactingMemStore.COMPACTING_MEMSTORE_INDEX_DEFAULT));<a name="line.106"></a>
+<span class="sourceLineNo">107</span> }<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span> @Override<a name="line.109"></a>
+<span class="sourceLineNo">110</span> public Cell copyCellInto(Cell cell) {<a name="line.110"></a>
+<span class="sourceLineNo">111</span> int size = KeyValueUtil.length(cell);<a name="line.111"></a>
+<span class="sourceLineNo">112</span> Preconditions.checkArgument(size >= 0, "negative size");<a name="line.112"></a>
+<span class="sourceLineNo">113</span> // Callers should satisfy large allocations directly from JVM since they<a name="line.113"></a>
+<span class="sourceLineNo">114</span> // don't cause fragmentation as badly.<a name="line.114"></a>
+<span class="sourceLineNo">115</span> if (size > maxAlloc) {<a name="line.115"></a>
+<span class="sourceLineNo">116</span> return null;<a name="line.116"></a>
+<span class="sourceLineNo">117</span> }<a name="line.117"></a>
+<span class="sourceLineNo">118</span> Chunk c = null;<a name="line.118"></a>
+<span class="sourceLineNo">119</span> int allocOffset = 0;<a name="line.119"></a>
+<span class="sourceLineNo">120</span> while (true) {<a name="line.120"></a>
+<span class="sourceLineNo">121</span> // Try to get the chunk<a name="line.121"></a>
+<span class="sourceLineNo">122</span> c = getOrMakeChunk();<a name="line.122"></a>
+<span class="sourceLineNo">123</span> // we may get null because the some other thread succeeded in getting the lock<a name="line.123"></a>
+<span class="sourceLineNo">124</span> // and so the current thread has to try again to make its chunk or grab the chunk<a name="line.124"></a>
+<span class="sourceLineNo">125</span> // that the other thread created<a name="line.125"></a>
+<span class="sourceLineNo">126</span> // Try to allocate from this chunk<a name="line.126"></a>
+<span class="sourceLineNo">127</span> if (c != null) {<a name="line.127"></a>
+<span class="sourceLineNo">128</span> allocOffset = c.alloc(size);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> if (allocOffset != -1) {<a name="line.129"></a>
+<span class="sourceLineNo">130</span> // We succeeded - this is the common case - small alloc<a name="line.130"></a>
+<span class="sourceLineNo">131</span> // from a big buffer<a name="line.131"></a>
+<span class="sourceLineNo">132</span> break;<a name="line.132"></a>
+<span class="sourceLineNo">133</span> }<a name="line.133"></a>
+<span class="sourceLineNo">134</span> // not enough space!<a name="line.134"></a>
+<span class="sourceLineNo">135</span> // try to retire this chunk<a name="line.135"></a>
+<span class="sourceLineNo">136</span> tryRetireChunk(c);<a name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span> }<a name="line.138"></a>
+<span class="sourceLineNo">139</span> return copyToChunkCell(cell, c.getData(), allocOffset, size);<a name="line.139"></a>
+<span class="sourceLineNo">140</span> }<a name="line.140"></a>
+<span class="sourceLineNo">141</span><a name="line.141"></a>
+<span class="sourceLineNo">142</span> /**<a name="line.142"></a>
+<span class="sourceLineNo">143</span> * Clone the passed cell by copying its data into the passed buf and create a cell with a chunkid<a name="line.143"></a>
+<span class="sourceLineNo">144</span> * out of it<a name="line.144"></a>
+<span class="sourceLineNo">145</span> */<a name="line.145"></a>
+<span class="sourceLineNo">146</span> private Cell copyToChunkCell(Cell cell, ByteBuffer buf, int offset, int len) {<a name="line.146"></a>
+<span class="sourceLineNo">147</span> int tagsLen = cell.getTagsLength();<a name="line.147"></a>
+<span class="sourceLineNo">148</span> if (cell instanceof ExtendedCell) {<a name="line.148"></a>
+<span class="sourceLineNo">149</span> ((ExtendedCell) cell).write(buf, offset);<a name="line.149"></a>
+<span class="sourceLineNo">150</span> } else {<a name="line.150"></a>
+<span class="sourceLineNo">151</span> // Normally all Cell impls within Server will be of type ExtendedCell. Just considering the<a name="line.151"></a>
+<span class="sourceLineNo">152</span> // other case also. The data fragments within Cell is copied into buf as in KeyValue<a name="line.152"></a>
+<span class="sourceLineNo">153</span> // serialization format only.<a name="line.153"></a>
+<span class="sourceLineNo">154</span> KeyValueUtil.appendTo(cell, buf, offset, true);<a name="line.154"></a>
+<span class="sourceLineNo">155</span> }<a name="line.155"></a>
+<span class="sourceLineNo">156</span> // TODO : write the seqid here. For writing seqId we should create a new cell type so<a name="line.156"></a>
+<span class="sourceLineNo">157</span> // that seqId is not used as the state<a name="line.157"></a>
+<span class="sourceLineNo">158</span> if (tagsLen == 0) {<a name="line.158"></a>
+<span class="sourceLineNo">159</span> // When tagsLen is 0, make a NoTagsByteBufferKeyValue version. This is an optimized class<a name="line.159"></a>
+<span class="sourceLineNo">160</span> // which directly return tagsLen as 0. So we avoid parsing many length components in<a name="line.160"></a>
+<span class="sourceLineNo">161</span> // reading the tagLength stored in the backing buffer. The Memstore addition of every Cell<a name="line.161"></a>
+<span class="sourceLineNo">162</span> // call getTagsLength().<a name="line.162"></a>
+<span class="sourceLineNo">163</span> return new NoTagByteBufferChunkCell(buf, offset, len, cell.getSequenceId());<a name="line.163"></a>
+<span class="sourceLineNo">164</span> } else {<a name="line.164"></a>
+<span class="sourceLineNo">165</span> return new ByteBufferChunkCell(buf, offset, len, cell.getSequenceId());<a name="line.165"></a>
+<span class="sourceLineNo">166</span> }<a name="line.166"></a>
+<span class="sourceLineNo">167</span> }<a name="line.167"></a>
+<span class="sourceLineNo">168</span><a name="line.168"></a>
+<span class="sourceLineNo">169</span> /**<a name="line.169"></a>
+<span class="sourceLineNo">170</span> * Close this instance since it won't be used any more, try to put the chunks<a name="line.170"></a>
+<span class="sourceLineNo">171</span> * back to pool<a name="line.171"></a>
+<span class="sourceLineNo">172</span> */<a name="line.172"></a>
+<span class="sourceLineNo">173</span> @Override<a name="line.173"></a>
+<span class="sourceLineNo">174</span> public void close() {<a name="line.174"></a>
+<span class="sourceLineNo">175</span> this.closed = true;<a name="line.175"></a>
+<span class="sourceLineNo">176</span> // We could put back the chunks to pool for reusing only when there is no<a name="line.176"></a>
+<span class="sourceLineNo">177</span> // opening scanner which will read their data<a name="line.177"></a>
+<span class="sourceLineNo">178</span> int count = openScannerCount.get();<a name="line.178"></a>
+<span class="sourceLineNo">179</span> if(count == 0) {<a name="line.179"></a>
+<span class="sourceLineNo">180</span> recycleChunks();<a name="line.180"></a>
+<span class="sourceLineNo">181</span> }<a name="line.181"></a>
+<span class="sourceLineNo">182</span> }<a name="line.182"></a>
+<span class="sourceLineNo">183</span><a name="line.183"></a>
+<span class="sourceLineNo">184</span> /**<a name="line.184"></a>
+<span class="sourceLineNo">185</span> * Called when opening a scanner on the data of this MemStoreLAB<a name="line.185"></a>
+<span class="sourceLineNo">186</span> */<a name="line.186"></a>
+<span class="sourceLineNo">187</span> @Override<a name="line.187"></a>
+<span class="sourceLineNo">188</span> public void incScannerCount() {<a name="line.188"></a>
+<span class="sourceLineNo">189</span> this.openScannerCount.incrementAndGet();<a name="line.189"></a>
+<span class="sourceLineNo">190</span> }<a name="line.190"></a>
+<span class="sourceLineNo">191</span><a name="line.191"></a>
+<span class="sourceLineNo">192</span> /**<a name="line.192"></a>
+<span class="sourceLineNo">193</span> * Called when closing a scanner on the data of this MemStoreLAB<a name="line.193"></a>
+<span class="sourceLineNo">194</span> */<a name="line.194"></a>
+<span class="sourceLineNo">195</span> @Override<a name="line.195"></a>
+<span class="sourceLineNo">196</span> public void decScannerCount() {<a name="line.196"></a>
+<span class="sourceLineNo">197</span> int count = this.openScannerCount.decrementAndGet();<a name="line.197"></a>
+<span class="sourceLineNo">198</span> if (this.closed && count == 0) {<a name="line.198"></a>
+<span class="sourceLineNo">199</span> recycleChunks();<a name="line.199"></a>
+<span class="sourceLineNo">200</span> }<a name="line.200"></a>
+<span class="sourceLineNo">201</span> }<a name="line.201"></a>
+<span class="sourceLineNo">202</span><a name="line.202"></a>
+<span class="sourceLineNo">203</span> private void recycleChunks() {<a name="line.203"></a>
+<span class="sourceLineNo">204</span> if (reclaimed.compareAndSet(false, true)) {<a name="line.204"></a>
+<span class="sourceLineNo">205</span> chunkCreator.putbackChunks(chunks);<a name="line.205"></a>
+<span class="sourceLineNo">206</span> }<a name="line.206"></a>
+<span class="sourceLineNo">207</span> }<a name="line.207"></a>
+<span class="sourceLineNo">208</span><a name="line.208"></a>
+<span class="sourceLineNo">209</span> /**<a name="line.209"></a>
+<span class="sourceLineNo">210</span> * Try to retire the current chunk if it is still<a name="line.210"></a>
+<span class="sourceLineNo">211</span> * <code>c</code>. Postcondition is that curChunk.get()<a name="line.211"></a>
+<span class="sourceLineNo">212</span> * != c<a name="line.212"></a>
+<span class="sourceLineNo">213</span> * @param c the chunk to retire<a name="line.213"></a>
+<span class="sourceLineNo">214</span> * @return true if we won the race to retire the chunk<a name="line.214"></a>
+<span class="sourceLineNo">215</span> */<a name="line.215"></a>
+<span class="sourceLineNo">216</span> private void tryRetireChunk(Chunk c) {<a name="line.216"></a>
+<span class="sourceLineNo">217</span> curChunk.compareAndSet(c, null);<a name="line.217"></a>
+<span class="sourceLineNo">218</span> // If the CAS succeeds, that means that we won the race<a name="line.218"></a>
+<span class="sourceLineNo">219</span> // to retire the chunk. We could use this opportunity to<a name="line.219"></a>
+<span class="sourceLineNo">220</span> // update metrics on external fragmentation.<a name="line.220"></a>
+<span class="sourceLineNo">221</span> //<a name="line.221"></a>
+<span class="sourceLineNo">222</span> // If the CAS fails, that means that someone else already<a name="line.222"></a>
+<span class="sourceLineNo">223</span> // retired the chunk for us.<a name="line.223"></a>
+<span class="sourceLineNo">224</span> }<a name="line.224"></a>
+<span class="sourceLineNo">225</span><a name="line.225"></a>
+<span class="sourceLineNo">226</span> /**<a name="line.226"></a>
+<span class="sourceLineNo">227</span> * Get the current chunk, or, if there is no current chunk,<a name="line.227"></a>
+<span class="sourceLineNo">228</span> * allocate a new one from the JVM.<a name="line.228"></a>
+<span class="sourceLineNo">229</span> */<a name="line.229"></a>
+<span class="sourceLineNo">230</span> private Chunk getOrMakeChunk() {<a name="line.230"></a>
+<span class="sourceLineNo">231</span> // Try to get the chunk<a name="line.231"></a>
+<span class="sourceLineNo">232</span> Chunk c = curChunk.get();<a name="line.232"></a>
+<span class="sourceLineNo">233</span> if (c != null) {<a name="line.233"></a>
+<span class="sourceLineNo">234</span> return c;<a name="line.234"></a>
+<span class="sourceLineNo">235</span> }<a name="line.235"></a>
+<span class="sourceLineNo">236</span> // No current chunk, so we want to allocate one. We race<a name="line.236"></a>
+<span class="sourceLineNo">237</span> // against other allocators to CAS in an uninitialized chunk<a name="line.237"></a>
+<span class="sourceLineNo">238</span> // (which is cheap to allocate)<a name="line.238"></a>
+<span class="sourceLineNo">239</span> if (lock.tryLock()) {<a name="line.239"></a>
+<span class="sourceLineNo">240</span> try {<a name="line.240"></a>
+<span class="sourceLineNo">241</span> // once again check inside the lock<a name="line.241"></a>
+<span class="sourceLineNo">242</span> c = curChunk.get();<a name="line.242"></a>
<span class="sourceLineNo">243</span> if (c != null) {<a name="line.243"></a>
-<span class="sourceLineNo">244</span> // set the curChunk. No need of CAS as only one thread will be here<a name="line.244"></a>
-<span class="sourceLineNo">245</span> curChunk.set(c);<a name="line.245"></a>
-<span class="sourceLineNo">246</span> chunks.add(c.getId());<a name="line.246"></a>
-<span class="sourceLineNo">247</span> return c;<a name="line.247"></a>
-<span class="sourceLineNo">248</span> }<a name="line.248"></a>
-<span class="sourceLineNo">249</span> } finally {<a name="line.249"></a>
-<span class="sourceLineNo">250</span> lock.unlock();<a name="line.250"></a>
-<span class="sourceLineNo">251</span> }<a name="line.251"></a>
-<span class="sourceLineNo">252</span> }<a name="line.252"></a>
-<span class="sourceLineNo">253</span> return null;<a name="line.253"></a>
-<span class="sourceLineNo">254</span> }<a name="line.254"></a>
-<span class="sourceLineNo">255</span><a name="line.255"></a>
-<span class="sourceLineNo">256</span> // Returning a new chunk, without replacing current chunk,<a name="line.256"></a>
-<span class="sourceLineNo">257</span> // meaning MSLABImpl does not make the returned chunk as CurChunk.<a name="line.257"></a>
-<span class="sourceLineNo">258</span> // The space on this chunk will be allocated externally<a name="line.258"></a>
-<span class="sourceLineNo">259</span> // The interface is only for external callers<a name="line.259"></a>
-<span class="sourceLineNo">260</span> @Override<a name="line.260"></a>
-<span class="sourceLineNo">261</span> public Chunk getNewExternalChunk() {<a name="line.261"></a>
-<span class="sourceLineNo">262</span> Chunk c = this.chunkCreator.getChunk();<a name="line.262"></a>
-<span class="sourceLineNo">263</span> chunks.add(c.getId());<a name="line.263"></a>
-<span class="sourceLineNo">264</span> return c;<a name="line.264"></a>
-<span class="sourceLineNo">265</span> }<a name="line.265"></a>
-<span class="sourceLineNo">266</span><a name="line.266"></a>
-<span class="sourceLineNo">267</span> @VisibleForTesting<a name="line.267"></a>
-<span class="sourceLineNo">268</span> Chunk getCurrentChunk() {<a name="line.268"></a>
-<span class="sourceLineNo">269</span> return this.curChunk.get();<a name="line.269"></a>
-<span class="sourceLineNo">270</span> }<a name="line.270"></a>
-<span class="sourceLineNo">271</span><a name="line.271"></a>
-<span class="sourceLineNo">272</span> @VisibleForTesting<a name="line.272"></a>
-<span class="sourceLineNo">273</span> BlockingQueue<Chunk> getPooledChunks() {<a name="line.273"></a>
-<span class="sourceLineNo">274</span> BlockingQueue<Chunk> pooledChunks = new LinkedBlockingQueue<>();<a name="line.274"></a>
-<span class="sourceLineNo">275</span> for (Integer id : this.chunks) {<a name="line.275"></a>
-<span class="sourceLineNo">276</span> Chunk chunk = chunkCreator.getChunk(id);<a name="line.276"></a>
-<span class="sourceLineNo">277</span> if (chunk != null && chunk.isFromPool()) {<a name="line.277"></a>
-<span class="sourceLineNo">278</span> pooledChunks.add(chunk);<a name="line.278"></a>
-<span class="sourceLineNo">279</span> }<a name="line.279"></a>
-<span class="sourceLineNo">280</span> }<a name="line.280"></a>
-<span class="sourceLineNo">281</span> return pooledChunks;<a name="line.281"></a>
-<span class="sourceLineNo">282</span> }<a name="line.282"></a>
-<span class="sourceLineNo">283</span>}<a name="line.283"></a>
+<span class="sourceLineNo">244</span> return c;<a name="line.244"></a>
+<span class="sourceLineNo">245</span> }<a name="line.245"></a>
+<span class="sourceLineNo">246</span> c = this.chunkCreator.getChunk(idxType);<a name="line.246"></a>
+<span class="sourceLineNo">247</span> if (c != null) {<a name="line.247"></a>
+<span class="sourceLineNo">248</span> // set the curChunk. No need of CAS as only one thread will be here<a name="line.248"></a>
+<span class="sourceLineNo">249</span> curChunk.set(c);<a name="line.249"></a>
+<span class="sourceLineNo">250</span> chunks.add(c.getId());<a name="line.250"></a>
+<span class="sourceLineNo">251</span> return c;<a name="line.251"></a>
+<span class="sourceLineNo">252</span> }<a name="line.252"></a>
+<span class="sourceLineNo">253</span> } finally {<a name="line.253"></a>
+<span class="sourceLineNo">254</span> lock.unlock();<a name="line.254"></a>
+<span class="sourceLineNo">255</span> }<a name="line.255"></a>
+<span class="sourceLineNo">256</span> }<a name="line.256"></a>
+<span class="sourceLineNo">257</span> return null;<a name="line.257"></a>
+<span class="sourceLineNo">258</span> }<a name="line.258"></a>
+<span class="sourceLineNo">259</span><a name="line.259"></a>
+<span class="sourceLineNo">260</span> /* Creating chunk to be used as index chunk in CellChunkMap, part of the chunks array.<a name="line.260"></a>
+<span class="sourceLineNo">261</span> ** Returning a new chunk, without replacing current chunk,<a name="line.261"></a>
+<span class="sourceLineNo">262</span> ** meaning MSLABImpl does not make the returned chunk as CurChunk.<a name="line.262"></a>
+<span class="sourceLineNo">263</span> ** The space on this chunk will be allocated externally.<a name="line.263"></a>
+<span class="sourceLineNo">264</span> ** The interface is only for external callers<a name="line.264"></a>
+<span class="sourceLineNo">265</span> */<a name="line.265"></a>
+<span class="sourceLineNo">266</span> @Override<a name="line.266"></a>
+<span class="sourceLineNo">267</span> public Chunk getNewExternalChunk() {<a name="line.267"></a>
+<span class="sourceLineNo">268</span> // the new chunk is going to be part of the chunk array and will always be referenced<a name="line.268"></a>
+<span class="sourceLineNo">269</span> Chunk c = this.chunkCreator.getChunk();<a name="line.269"></a>
+<span class="sourceLineNo">270</span> chunks.add(c.getId());<a name="line.270"></a>
+<span class="sourceLineNo">271</span> return c;<a name="line.271"></a>
+<span class="sourceLineNo">272</span> }<a name="line.272"></a>
+<span class="sourceLineNo">273</span><a name="line.273"></a>
+<span class="sourceLineNo">274</span> @VisibleForTesting<a name="line.274"></a>
+<span class="sourceLineNo">275</span> Chunk getCurrentChunk() {<a name="line.275"></a>
+<span class="sourceLineNo">276</span> return this.curChunk.get();<a name="line.276"></a>
+<span class="sourceLineNo">277</span> }<a name="line.277"></a>
+<span class="sourceLineNo">278</span><a name="line.278"></a>
+<span class="sourceLineNo">279</span> @VisibleForTesting<a name="line.279"></a>
+<span class="sourceLineNo">280</span> BlockingQueue<Chunk> getPooledChunks() {<a name="line.280"></a>
+<span class="sourceLineNo">281</span> BlockingQueue<Chunk> pooledChunks = new LinkedBlockingQueue<>();<a name="line.281"></a>
+<span class="sourceLineNo">282</span> for (Integer id : this.chunks) {<a name="line.282"></a>
+<span class="sourceLineNo">283</span> Chunk chunk = chunkCreator.getChunk(id);<a name="line.283"></a>
+<span class="sourceLineNo">284</span> if (chunk != null && chunk.isFromPool()) {<a name="line.284"></a>
+<span class="sourceLineNo">285</span> pooledChunks.add(chunk);<a name="line.285"></a>
+<span class="sourceLineNo">286</span> }<a name="line.286"></a>
+<span class="sourceLineNo">287</span> }<a name="line.287"></a>
+<span class="sourceLineNo">288</span> return pooledChunks;<a name="line.288"></a>
+<span class="sourceLineNo">289</span> }<a name="line.289"></a>
+<span class="sourceLineNo">290</span><a name="line.290"></a>
+<span class="sourceLineNo">291</span> @VisibleForTesting Integer getNumOfChunksReturnedToPool() {<a name="line.291"></a>
+<span class="sourceLineNo">292</span> int i = 0;<a name="line.292"></a>
+<span class="sourceLineNo">293</span> for (Integer id : this.chunks) {<a name="line.293"></a>
+<span class="sourceLineNo">294</span> if (chunkCreator.isChunkInPool(id)) {<a name="line.294"></a>
+<span class="sourceLineNo">295</span> i++;<a name="line.295"></a>
+<span class="sourceLineNo">296</span> }<a name="line.296"></a>
+<span class="sourceLineNo">297</span> }<a name="line.297"></a>
+<span class="sourceLineNo">298</span> return i;<a name="line.298"></a>
+<span class="sourceLineNo">299</span> }<a name="line.299"></a>
+<span class="sourceLineNo">300</span>}<a name="line.300"></a>