You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/30 02:53:56 UTC
[GitHub] [flink] pltbkd opened a new pull request, #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
pltbkd opened a new pull request, #20108:
URL: https://github.com/apache/flink/pull/20108
## What is the purpose of the change
There's a bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException if the pool is initialized without any buffers. It may cause other metrics failing to report.
## Brief change log
- Return 0 as the requested segments usage if the buffer pool is empty.
## Verifying this change
This change added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20108:
URL: https://github.com/apache/flink/pull/20108#issuecomment-1170696790
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4aa7acbc536b1c168b0de658664e4e4e0c1343c0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4aa7acbc536b1c168b0de658664e4e4e0c1343c0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4aa7acbc536b1c168b0de658664e4e4e0c1343c0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #20108:
URL: https://github.com/apache/flink/pull/20108#issuecomment-1174698823
Merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #20108:
URL: https://github.com/apache/flink/pull/20108#issuecomment-1171870337
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii closed pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii closed pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
URL: https://github.com/apache/flink/pull/20108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #20108:
URL: https://github.com/apache/flink/pull/20108#issuecomment-1170922160
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #20108: [FLINK-28240][network] Fix the bug that NetworkBufferPool#getRequestedSegmentsUsage may throw ArithmeticException.
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on PR #20108:
URL: https://github.com/apache/flink/pull/20108#issuecomment-1174661292
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org