You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anindya Sinha <an...@apple.com> on 2016/01/30 02:35:35 UTC
Review Request 42996: [5 of 7] Add unit tests for sharing of
resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42996/
-----------------------------------------------------------
Review request for mesos and Adam B.
Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324
Repository: mesos
Description
-------
Add unit tests for sharing of resources.
Diffs
-----
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488
src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a
Diff: https://reviews.apache.org/r/42996/diff/
Testing
-------
make check done.
Thanks,
Anindya Sinha
Re: Review Request 42996: [5 of 7] Add unit tests for sharing of
resources.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42996/#review117102
-----------------------------------------------------------
src/tests/resources_tests.cpp (lines 2036 - 2043)
<https://reviews.apache.org/r/42996/#comment178189>
Why need this case? I think that it does not related to shared resource and already covered by CreatePersistentVolume.
You may want to test the shared cases here by creating a shared volume.
- Guangya Liu
On 一月 30, 2016, 1:35 a.m., Anindya Sinha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42996/
> -----------------------------------------------------------
>
> (Updated 一月 30, 2016, 1:35 a.m.)
>
>
> Review request for mesos and Adam B.
>
>
> Bugs: MESOS-4324
> https://issues.apache.org/jira/browse/MESOS-4324
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add unit tests for sharing of resources.
>
>
> Diffs
> -----
>
> src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
> src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488
> src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
> src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a
>
> Diff: https://reviews.apache.org/r/42996/diff/
>
>
> Testing
> -------
>
> make check done.
>
>
> Thanks,
>
> Anindya Sinha
>
>
Re: Review Request 42996: Add unit tests for sharing of resources.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42996/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 10:57 p.m.)
Review request for mesos and Adam B.
Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324
Repository: mesos
Description
-------
Add unit tests for sharing of resources.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 0acfc098750ff8ff9505207b983a34c1ccf3ad06
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
src/tests/mesos.hpp e07d8aa6f1e507a91ce70763aafa134bdd9a7ec8
src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a
Diff: https://reviews.apache.org/r/42996/diff/
Testing
-------
make check done.
Thanks,
Anindya Sinha
Re: Review Request 42996: Add unit tests for sharing of resources.
Posted by Anindya Sinha <an...@apple.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42996/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 12:38 a.m.)
Review request for mesos and Adam B.
Summary (updated)
-----------------
Add unit tests for sharing of resources.
Bugs: MESOS-4324
https://issues.apache.org/jira/browse/MESOS-4324
Repository: mesos
Description
-------
Add unit tests for sharing of resources.
Diffs (updated)
-----
src/tests/master_validation_tests.cpp 6fae01fa1833ae05ec82618a4ae28ac5bd275bd5
src/tests/mesos.hpp c2bae4767ee7372c796bfad44ed1e86db7dd3488
src/tests/persistent_volume_tests.cpp cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0
src/tests/resources_tests.cpp 4b25e82c13e4f46c73803f773db90f269c09c48a
Diff: https://reviews.apache.org/r/42996/diff/
Testing
-------
make check done.
Thanks,
Anindya Sinha