[GitHub] [superset] bkyryliuk commented on a diff in pull request #22659: fix(bootstrap-data): always check flashes

[GitBox <gi...@apache.org>]

bkyryliuk commented on code in PR #22659:
URL: https://github.com/apache/superset/pull/22659#discussion_r1066040320


##########
superset/embedded/view.py:
##########
@@ -77,7 +77,7 @@ def embedded(
         )
 
         bootstrap_data = {
-            "common": common_bootstrap_payload(g.user),
+            "common": common_bootstrap_payload(),

Review Comment:
   I would suggest to keep user as an argument here, last time I made a bug and assumed that common_bootstrap_payload was user agnostic as it did not take any params



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org