You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/06 08:35:45 UTC
[GitHub] [spark] MaxGekk opened a new pull request #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
MaxGekk opened a new pull request #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474
### What changes were proposed in this pull request?
- Rewrite the `convertTz` and `daysToMillis` methods of `DateTimeUtils` using Java 8 time API
- Remove `DateTimeUtils. getOffsetFromLocalMillis`
- Change types of `convertTz` parameters from `TimeZone` to `ZoneId`. This allow to avoid unnecessary conversions `TimeZone` -> `ZoneId`
### Why are the changes needed?
- Simplifies the code, and make it more maintainable
- Switches `convertTz` and `daysToMillis` on Proleptic Gregorian calendar used by Java 8 time classes by default. That makes the functions consistent to other date-time functions.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
By existing test suite `DateTimeUtilsSuite`, `DateFunctionsSuite` and `DateExpressionsSuite`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282362
**[Test build #118023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118023/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583280324
jenkins, retest this, please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#discussion_r376219994
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1176,14 +1176,14 @@ case class FromUTCTimestamp(left: Expression, right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzClass = classOf[TimeZone].getName
+ val tzClass = classOf[ZoneId].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
val escapedTz = StringEscapeUtils.escapeJava(tz.toString)
val tzTerm = ctx.addMutableState(tzClass, "tz",
- v => s"""$v = $dtu.getTimeZone("$escapedTz");""")
+ v => s"""$v = $dtu.getZoneId("$escapedTz");""")
val utcTerm = "tzUTC"
ctx.addImmutableStateIfNotExists(tzClass, utcTerm,
- v => s"""$v = $dtu.getTimeZone("UTC");""")
+ v => s"""$v = java.time.ZoneOffset.UTC;""")
Review comment:
This is a constant now, do we still a mutable state for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260407
**[Test build #118018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118018/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583278741
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850384
**[Test build #117989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117989/testReport)** for PR 27474 at commit [`3d4456a`](https://github.com/apache/spark/commit/3d4456a7507a7dcbbdb710b60165107ab13b771c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583111449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118000/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582998458
**[Test build #118000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118000/testReport)** for PR 27474 at commit [`41760c4`](https://github.com/apache/spark/commit/41760c442da17763e550baebd1a1bc326c914dc6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583544110
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582829120
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117983/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port `convertTz()`
and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582846644
**[Test build #117985 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117985/testReport)** for PR 27474 at commit [`a83a258`](https://github.com/apache/spark/commit/a83a258dacadad55848bab7fec942336ddb07df8).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582846868
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582799735
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22749/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#discussion_r376237228
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1176,14 +1176,14 @@ case class FromUTCTimestamp(left: Expression, right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzClass = classOf[TimeZone].getName
+ val tzClass = classOf[ZoneId].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
val escapedTz = StringEscapeUtils.escapeJava(tz.toString)
val tzTerm = ctx.addMutableState(tzClass, "tz",
- v => s"""$v = $dtu.getTimeZone("$escapedTz");""")
+ v => s"""$v = $dtu.getZoneId("$escapedTz");""")
val utcTerm = "tzUTC"
ctx.addImmutableStateIfNotExists(tzClass, utcTerm,
- v => s"""$v = $dtu.getTimeZone("UTC");""")
+ v => s"""$v = java.time.ZoneOffset.UTC;""")
Review comment:
No, we don't. I have removed the state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#discussion_r376237287
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1382,14 +1382,14 @@ case class ToUTCTimestamp(left: Expression, right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzClass = classOf[TimeZone].getName
+ val tzClass = classOf[ZoneId].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
val escapedTz = StringEscapeUtils.escapeJava(tz.toString)
val tzTerm = ctx.addMutableState(tzClass, "tz",
- v => s"""$v = $dtu.getTimeZone("$escapedTz");""")
+ v => s"""$v = $dtu.getZoneId("$escapedTz");""")
val utcTerm = "tzUTC"
ctx.addImmutableStateIfNotExists(tzClass, utcTerm,
- v => s"""$v = $dtu.getTimeZone("UTC");""")
+ v => s"""$v = java.time.ZoneOffset.UTC;""")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850957
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22783/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583278751
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118018/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22788/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583111439
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582802087
**[Test build #117985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117985/testReport)** for PR 27474 at commit [`a83a258`](https://github.com/apache/spark/commit/a83a258dacadad55848bab7fec942336ddb07df8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583278635
**[Test build #118018 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118018/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22754/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582846878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117985/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850384
**[Test build #117989 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117989/testReport)** for PR 27474 at commit [`3d4456a`](https://github.com/apache/spark/commit/3d4456a7507a7dcbbdb710b60165107ab13b771c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582963954
**[Test build #117989 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117989/testReport)** for PR 27474 at commit [`3d4456a`](https://github.com/apache/spark/commit/3d4456a7507a7dcbbdb710b60165107ab13b771c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582965040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582965040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583110811
**[Test build #118000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118000/testReport)** for PR 27474 at commit [`41760c4`](https://github.com/apache/spark/commit/41760c442da17763e550baebd1a1bc326c914dc6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282792
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22788/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582829107
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260778
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22783/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582799735
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22749/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port `convertTz()`
and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582802087
**[Test build #117985 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117985/testReport)** for PR 27474 at commit [`a83a258`](https://github.com/apache/spark/commit/a83a258dacadad55848bab7fec942336ddb07df8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582794232
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583975549
+1 sorry for late response.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582794232
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582829120
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117983/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583278741
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583376359
**[Test build #118023 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118023/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582794239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22748/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583376907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118023/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583119849
@srowen @cloud-fan @HyukjinKwon @dongjoon-hyun Please, review this bug fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-582998458
**[Test build #118000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118000/testReport)** for PR 27474 at commit [`41760c4`](https://github.com/apache/spark/commit/41760c442da17763e550baebd1a1bc326c914dc6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582846868
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port `convertTz()`
and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582828987
**[Test build #117983 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117983/testReport)** for PR 27474 at commit [`b2a134f`](https://github.com/apache/spark/commit/b2a134fb34e881049bd2166b126492daffb30ee7).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260407
**[Test build #118018 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118018/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260771
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583376899
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582999316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22765/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [WIP] Port `convertTz()`
and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582793780
**[Test build #117983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117983/testReport)** for PR 27474 at commit [`b2a134f`](https://github.com/apache/spark/commit/b2a134fb34e881049bd2166b126492daffb30ee7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582846878
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117985/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583376899
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582965060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117989/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582999316
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22765/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583111449
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118000/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583278751
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118018/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583260771
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#discussion_r376220075
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1382,14 +1382,14 @@ case class ToUTCTimestamp(left: Expression, right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzClass = classOf[TimeZone].getName
+ val tzClass = classOf[ZoneId].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
val escapedTz = StringEscapeUtils.escapeJava(tz.toString)
val tzTerm = ctx.addMutableState(tzClass, "tz",
- v => s"""$v = $dtu.getTimeZone("$escapedTz");""")
+ v => s"""$v = $dtu.getZoneId("$escapedTz");""")
val utcTerm = "tzUTC"
ctx.addImmutableStateIfNotExists(tzClass, utcTerm,
- v => s"""$v = $dtu.getTimeZone("UTC");""")
+ v => s"""$v = java.time.ZoneOffset.UTC;""")
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583111439
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582794239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22748/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582799723
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582999305
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582829107
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582793780
**[Test build #117983 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117983/testReport)** for PR 27474 at commit [`b2a134f`](https://github.com/apache/spark/commit/b2a134fb34e881049bd2166b126492daffb30ee7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282780
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#discussion_r376219994
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -1176,14 +1176,14 @@ case class FromUTCTimestamp(left: Expression, right: Expression)
|long ${ev.value} = 0;
""".stripMargin)
} else {
- val tzClass = classOf[TimeZone].getName
+ val tzClass = classOf[ZoneId].getName
val dtu = DateTimeUtils.getClass.getName.stripSuffix("$")
val escapedTz = StringEscapeUtils.escapeJava(tz.toString)
val tzTerm = ctx.addMutableState(tzClass, "tz",
- v => s"""$v = $dtu.getTimeZone("$escapedTz");""")
+ v => s"""$v = $dtu.getZoneId("$escapedTz");""")
val utcTerm = "tzUTC"
ctx.addImmutableStateIfNotExists(tzClass, utcTerm,
- v => s"""$v = $dtu.getTimeZone("UTC");""")
+ v => s"""$v = java.time.ZoneOffset.UTC;""")
Review comment:
This is a constant now, do we still need a mutable state for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582965060
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117989/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282362
**[Test build #118023 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118023/testReport)** for PR 27474 at commit [`f313646`](https://github.com/apache/spark/commit/f31364612d7d0ae57f43740394a6e511825b3a43).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`convertTz()` and `daysToMillis()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `convertTz()` and `daysToMillis()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582799723
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582999305
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474:
[SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583282780
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850957
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27474: [SPARK-30752][SQL] Fix
`to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583241273
LGTM except one comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27474: [SPARK-30752][SQL]
Fix `to_utc_timestamp` on daylight saving day
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27474: [SPARK-30752][SQL] Fix `to_utc_timestamp` on daylight saving day
URL: https://github.com/apache/spark/pull/27474#issuecomment-583376907
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118023/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27474: [WIP] Port
`DateTimeUtils.convertTz()` on Java 8 time API
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27474: [WIP] Port `DateTimeUtils.convertTz()` on Java 8 time API
URL: https://github.com/apache/spark/pull/27474#issuecomment-582850967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22754/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org