You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/05/01 07:27:34 UTC

Review Request 33746: Improve logging of clone flags for linux_launcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/
-----------------------------------------------------------

Review request for mesos, Chi Zhang and Jie Yu.


Repository: mesos


Description
-------

Improve logging of clone flags for linux_launcher.


Diffs
-----

  src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
  src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 

Diff: https://reviews.apache.org/r/33746/diff/


Testing
-------

Example output:

I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID


Thanks,

Ian Downes

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review82238
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33746]

All tests passed.

- Mesos ReviewBot


On May 1, 2015, 5:27 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33746/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 5:27 a.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improve logging of clone flags for linux_launcher.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 
> 
> Diff: https://reviews.apache.org/r/33746/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review82236
-----------------------------------------------------------

Ship it!


Ship It!


src/linux/ns.hpp
<https://reviews.apache.org/r/33746/#comment132932>

    add some comment for this function?


- Chi Zhang


On May 1, 2015, 5:27 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33746/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 5:27 a.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improve logging of clone flags for linux_launcher.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 
> 
> Diff: https://reviews.apache.org/r/33746/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Ian Downes <ia...@gmail.com>.

> On May 1, 2015, 10:43 a.m., Jie Yu wrote:
> > src/linux/ns.hpp, line 305
> > <https://reviews.apache.org/r/33746/diff/1/?file=947057#file947057line305>
> >
> >     Consider s/stringify/names/ ?

I'd expect names() to return a vector which isn't what this does. Changed to stringify(int flags).


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review82261
-----------------------------------------------------------


On April 30, 2015, 10:27 p.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33746/
> -----------------------------------------------------------
> 
> (Updated April 30, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improve logging of clone flags for linux_launcher.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 
> 
> Diff: https://reviews.apache.org/r/33746/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review82261
-----------------------------------------------------------

Ship it!



src/linux/ns.hpp
<https://reviews.apache.org/r/33746/#comment132962>

    Consider s/stringify/names/ ?



src/linux/ns.hpp
<https://reviews.apache.org/r/33746/#comment132960>

    Using a map here is more appropriate and avoids the extra type?
    
    ```
    map<int, std::string> names = {
      {CLONE_NEWIPC, "CLONE_NEWIPC"},
      {CLONE_NEWNET, "CLONE_NEWNET"},
      ...
    }
    
    std::vector<std::string> namespaces;
    foreachpair (int flag, const std::string& name, names) {
      if (clone & flag) {
        namespaces.push_back(name);
      }
    }
    
    return strings::join(" | ", namesapces);
    ```


- Jie Yu


On May 1, 2015, 5:27 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33746/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 5:27 a.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improve logging of clone flags for linux_launcher.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 
> 
> Diff: https://reviews.apache.org/r/33746/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/#review83555
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33746]

All tests passed.

- Mesos ReviewBot


On May 13, 2015, 12:23 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33746/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 12:23 a.m.)
> 
> 
> Review request for mesos, Chi Zhang and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improve logging of clone flags for linux_launcher.
> 
> 
> Diffs
> -----
> 
>   src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
>   src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 
> 
> Diff: https://reviews.apache.org/r/33746/diff/
> 
> 
> Testing
> -------
> 
> Example output:
> 
> I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 33746: Improve logging of clone flags for linux_launcher.

Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33746/
-----------------------------------------------------------

(Updated May 12, 2015, 5:23 p.m.)


Review request for mesos, Chi Zhang and Jie Yu.


Repository: mesos


Description
-------

Improve logging of clone flags for linux_launcher.


Diffs (updated)
-----

  src/linux/ns.hpp 87ff82c2efdf26f38b81f8440640bf04def05931 
  src/slave/containerizer/linux_launcher.cpp b9e22e3c70bed0c29e2ca8632411789d33f779a8 

Diff: https://reviews.apache.org/r/33746/diff/


Testing
-------

Example output:

I0501 05:13:25.414758  7838 linux_launcher.cpp:212] Cloning child process with flags = CLONE_NEWNS | CLONE_NEWPID


Thanks,

Ian Downes