You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "dombizita (via GitHub)" <gi...@apache.org> on 2023/03/09 11:00:45 UTC
[GitHub] [ozone] dombizita opened a new pull request, #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
dombizita opened a new pull request, #4369:
URL: https://github.com/apache/ozone/pull/4369
## What changes were proposed in this pull request?
previous this change the `DatanodeDetails` didn't store any information regarding the HTTP and HTTPS ports of the datanode. there was a [conversation](https://github.com/apache/ozone/pull/4278#issuecomment-1439184020) on how to add the ports in a backward compatible way and we decided to add a new HDDS layout version as `WEBUI_PORTS_IN_DATANODEDETAILS`. I created a `BelongsToHDDSLayoutVersion` annotation and used it to annotate the new HTTP and HTTPS ports with the new layout version. in the `getDatanodeDetailsYaml` when we are adding the ports I checked if the port has this annotation and checked if the current layout version is smaller than the layout version of `WEBUI_PORTS_IN_DATANODEDETAILS` and in that case I am not writing the ports in to the `DatanodeDetails` yaml file.
I needed to change the MLV in of the compat tests as the latest one is 5 now. also as not the `DATANODE_SCHEMA_V3` is the latest HDDS layout version anymore I changed some tests to not require exact match with the versions in the `TestDatanodeUpgradeToSchemaV3.java`.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7817
## How was this patch tested?
green CI on my fork: https://github.com/dombizita/ozone/actions/runs/4369081456/jobs/7650370829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1145727303
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
See #4456 for HDDS-6633 PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1140320846
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
Review Comment:
OK, let's add a separate version. However, I think it should be lower than the one for http ports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1131733720
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
Review Comment:
I didn't add the annotation to the `RATIS_DATASTREAM` yet, do you think that would require a new `HDDSLayoutFeature`? or should I rename the `WEBUI_PORTS_IN_DATANODEDETAILS` to something more general regarding "ports presented in 1.4.0"? I am not sure what would be the best solution for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4369:
URL: https://github.com/apache/ozone/pull/4369
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1144014914
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
In offline discussion with @dombizita and @fapifta we agreed that the 1.4.0 upgrade test should be added separately, before this PR. Thanks @errose28 for the info on your work related to that.
Also, ideally this PR should be split into two:
* adding the framework to handle new ports, and applying it to RATIS_DATASTREAM
* adding the new HTTP ports
each with a new layout version, and bumping expected version after finalization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1131055734
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
Review Comment:
`RATIS_DATASTREAM` is also a new port after 1.3.0, so shouldn't it be annotated?
(We can split the task into two (1. introducing backwards-compatible handling of ports, 2. adding the new http ports) if you prefer.)
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
+ @BelongsToHDDSLayoutVersion(HDDSLayoutFeature
+ .WEBUI_PORTS_IN_DATANODEDETAILS)
+ HTTP,
Review Comment:
nit: for readability, please add static import for `WEBUI_PORTS_IN_DATANODEDETAILS`
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java:
##########
@@ -219,11 +226,31 @@ public void setCurrentVersion(int version) {
}
private static DatanodeDetailsYaml getDatanodeDetailsYaml(
- DatanodeDetails datanodeDetails) {
+ DatanodeDetails datanodeDetails, ConfigurationSource conf)
+ throws IOException {
+
+ DatanodeLayoutStorage datanodeLayoutStorage
+ = new DatanodeLayoutStorage(conf, datanodeDetails.getUuidString());
Map<String, Integer> portDetails = new LinkedHashMap<>();
if (!CollectionUtils.isEmpty(datanodeDetails.getPorts())) {
for (DatanodeDetails.Port port : datanodeDetails.getPorts()) {
+ Field f = null;
+ try {
+ f = port.getName().getClass()
+ .getDeclaredField(port.getName().toString());
Review Comment:
nit: use `Enum.name()` instead of `Enum.toString()`, which may be overridden
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java:
##########
@@ -219,11 +226,31 @@ public void setCurrentVersion(int version) {
}
private static DatanodeDetailsYaml getDatanodeDetailsYaml(
- DatanodeDetails datanodeDetails) {
+ DatanodeDetails datanodeDetails, ConfigurationSource conf)
+ throws IOException {
+
+ DatanodeLayoutStorage datanodeLayoutStorage
+ = new DatanodeLayoutStorage(conf, datanodeDetails.getUuidString());
Map<String, Integer> portDetails = new LinkedHashMap<>();
if (!CollectionUtils.isEmpty(datanodeDetails.getPorts())) {
for (DatanodeDetails.Port port : datanodeDetails.getPorts()) {
+ Field f = null;
+ try {
+ f = port.getName().getClass()
+ .getDeclaredField(port.getName().toString());
+ } catch (NoSuchFieldException e) {
+ e.printStackTrace();
Review Comment:
I think we should add a `Logger` in `DatanodeIdYaml` and log this as an error (I guess it really shouldn't happen).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1144784143
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
okay, thanks @errose28 @adoroszlai @fapifta, I converted this PR to draft and I'll come back to it once the other two are merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1132473584
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
Review Comment:
I was pondering the same question about a proper name for the layout feature. Maybe something like `OMITS_UNSUPPORTED_PORTS_IN_DATANODE_DETAILS`.
Adding a separate layout feature for `RATIS_DATASTREAM` seems overkill, but coming up with a name would be easier then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1132539825
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/protocol/DatanodeDetails.java:
##########
@@ -802,7 +804,13 @@ public static final class Port {
*/
public enum Name {
STANDALONE, RATIS, REST, REPLICATION, RATIS_ADMIN, RATIS_SERVER,
- RATIS_DATASTREAM;
+ RATIS_DATASTREAM,
Review Comment:
Handling of ports is pretty interesting in the yaml file.
The only call to persist the DN details object to the YAML is when the state machine runs the SetNodeOperationalStateCommandHandler code, as when the InitDatanodeState runs, the ports were not set so far.
So In a datanode that was always in service since it was first added there are no ports in the datanode.id file.
With that the RATIS_DATASTREAM port addition was not marked as a compat problem by our upgrade/downgrade tests. HTTP/HTTPS ports are added before the InitDatanodeState runs, hence they are saved. I believe we can not add them later as with the other ports.
So for the RATIS_DATASTREAM this problem will appear if someone upgrades a cluster, changes a node's operational state (decomm/offline then recomm) and then downgrades.
I think it is still a compatibility problem, but if we want to handle it, I strongly suggest to have a separate metadata layout version for that, than trying to come up with a better name, if we add more ports this will create an example and then whatever name we came up would become obsolete...
Adding a new layoutversion is cheap, and as far as I can tell it does not affect performance too much either.
@errose28 please chime in if adding more layotuversions have a perf impact and my knowledge is obsolete/wrong about this part. Also please chime in to review the changes if you have some time ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] errose28 commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1143994527
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
I should have a PR for HDDS-6633 within the next day or two. I'm just ironing out some minor errors on my [fork](https://github.com/errose28/ozone/tree/improve-upgrade-acc-tests). This will both add downgrade testing for 1.4.0 (master) to 1.3.0, and refactor the upgrade acceptance tests so we can add new versions much easier. We may want to hold off on upgrade acceptance test changes in this PR until that is done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1131059856
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java:
##########
@@ -219,11 +226,31 @@ public void setCurrentVersion(int version) {
}
private static DatanodeDetailsYaml getDatanodeDetailsYaml(
- DatanodeDetails datanodeDetails) {
+ DatanodeDetails datanodeDetails, ConfigurationSource conf)
+ throws IOException {
+
+ DatanodeLayoutStorage datanodeLayoutStorage
+ = new DatanodeLayoutStorage(conf, datanodeDetails.getUuidString());
Map<String, Integer> portDetails = new LinkedHashMap<>();
if (!CollectionUtils.isEmpty(datanodeDetails.getPorts())) {
for (DatanodeDetails.Port port : datanodeDetails.getPorts()) {
+ Field f = null;
+ try {
+ f = port.getName().getClass()
Review Comment:
nit: `port.getName().getClass()` can be a constant `DatanodeDetails.Port.Name.class`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] dombizita commented on pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "dombizita (via GitHub)" <gi...@apache.org>.
dombizita commented on PR #4369:
URL: https://github.com/apache/ozone/pull/4369#issuecomment-1461811532
please take a look at it @fapifta @adoroszlai @errose28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1144569866
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
@dombizita I suggest to close this PR than, and wait for HDDS-6633 to be fixed, after that let's add the upgrade framework changes and the solution to the RATIS_DATASTREAM port as part of HDDS-8239 and once that is ready, we can turn back to this change.
I have set the links to note the relation of the JIRA tickets, and assigned HDDS-8239 to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1131039674
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/DatanodeIdYaml.java:
##########
@@ -219,11 +226,31 @@ public void setCurrentVersion(int version) {
}
private static DatanodeDetailsYaml getDatanodeDetailsYaml(
- DatanodeDetails datanodeDetails) {
+ DatanodeDetails datanodeDetails, ConfigurationSource conf)
+ throws IOException {
+
+ DatanodeLayoutStorage datanodeLayoutStorage
+ = new DatanodeLayoutStorage(conf, datanodeDetails.getUuidString());
Map<String, Integer> portDetails = new LinkedHashMap<>();
if (!CollectionUtils.isEmpty(datanodeDetails.getPorts())) {
for (DatanodeDetails.Port port : datanodeDetails.getPorts()) {
+ Field f = null;
+ try {
+ f = port.getName().getClass()
+ .getDeclaredField(port.getName().toString());
+ } catch (NoSuchFieldException e) {
+ e.printStackTrace();
Review Comment:
Is this exception even possible to be thrown?
I believe it is impossible to get a port from the datanodeDetails object that does not have a name defined in the enum.
Still, I think, as printStackTrace writes to the stderr, this e.printStackTrace() should be either replaced with a simple comment that describes why we do not expect the exception here, or it should be replaced with logging at least.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] fapifta commented on pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "fapifta (via GitHub)" <gi...@apache.org>.
fapifta commented on PR #4369:
URL: https://github.com/apache/ozone/pull/4369#issuecomment-1464000386
I have restarted the failed test as it seemed an irrelevant failure (SCM stuck in safe mode after successfully exiting a couple of times already).
I am +1 for the changes to be committed, but I would like to see if @errose28 can also review, and how @adoroszlai sees my opinion regarding the RATIS_DATASTREAM port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #4369: HDDS-7817. Add HTTP and HTTPS ports to DatanodeDetails
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #4369:
URL: https://github.com/apache/ozone/pull/4369#discussion_r1140319666
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
Since 1.3.0 is released, I think we should keep this at 4, and introduce a new upgrade subdir for 1.3.0-1.4.0.
##########
hadoop-ozone/dist/src/main/compose/upgrade/upgrades/non-rolling-upgrade/1.2.1-1.3.0/callback.sh:
##########
@@ -70,7 +70,7 @@ with_old_version_downgraded() {
}
with_new_version_finalized() {
- _check_hdds_mlvs 4
+ _check_hdds_mlvs 5
Review Comment:
Since 1.3.0 is already released, I think we should keep this at 4, and introduce a new upgrade subdir for 1.3.0-1.4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org