You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/12/19 07:42:17 UTC
[GitHub] [incubator-pegasus] empiredan opened a new issue, #1299: Feature: decide whether two C strings are equal and support CHECK_STREQ* and CHECK_STRNE*
empiredan opened a new issue, #1299:
URL: https://github.com/apache/incubator-pegasus/issues/1299
While asserting equality between two C strings now we have to check if `strcmp` returns 0, for example:
```c++
CHECK_EQ_MSG(std::strcmp(prototype->name(), iter->second->prototype()->name()),
0,
"new prototype '{}' is inconsistent with old prototype '{}' for entity '{}'",
prototype->name(),
iter->second->prototype()->name(),
id);
```
We can support CHECK_STREQ* and CHECK_STRNE* in common macros for C strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan closed issue #1299: Feature: decide whether two C strings are equal and support CHECK_STREQ* and CHECK_STRNE*
Posted by GitBox <gi...@apache.org>.
empiredan closed issue #1299: Feature: decide whether two C strings are equal and support CHECK_STREQ* and CHECK_STRNE*
URL: https://github.com/apache/incubator-pegasus/issues/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org