You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/03/14 18:15:12 UTC
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6392
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
[DOCS] Take out 'work in progress' language from impala_intro
Leave behind a reference that says we got rid of all 'Cloudera Impala'
etc., but take out the wording that states this is an ongoing activity.
Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
---
M docs/topics/impala_intro.xml
1 file changed, 1 insertion(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/6392/1
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
[DOCS] Take out 'work in progress' language from impala_intro
Leave behind a reference that says we got rid of all 'Cloudera Impala'
etc., but take out the wording that states this is an ongoing activity.
Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Reviewed-on: http://gerrit.cloudera.org:8080/6392
Reviewed-by: Laurel Hale <la...@cloudera.com>
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_intro.xml
1 file changed, 1 insertion(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laurel Hale: Looks good to me, but someone else must approve
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Posted by "Laurel Hale (Code Review)" <ge...@cloudera.org>.
Laurel Hale has posted comments on this change.
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Files build cleanly, text displays as expected in html & pdf, all okay in source XML. I'm +1'ing this, but the comma and period should be placed within the double quotation marks.
http://gerrit.cloudera.org:8080/#/c/6392/1/docs/topics/impala_intro.xml
File docs/topics/impala_intro.xml:
PS1, Line 54: ,
Typically in American English, the comma and periods are placed within the double quotation marks. In British English this is reversed.
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
Patch Set 1: Code-Review+2
But IBM granted an exemption for technical communication because the quotation marks are so often significant in a computer perspective. Maybe noone remembers except me!
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Take out 'work in progress' language from impala intro
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: [DOCS] Take out 'work in progress' language from impala_intro
......................................................................
Patch Set 1:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/99/
--
To view, visit http://gerrit.cloudera.org:8080/6392
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3db9e1a9c1e4acf49ce072eceee2ba437590bf8
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-HasComments: No